-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: modifying license enrollment endpoint to support other subsidies #1709
feat: modifying license enrollment endpoint to support other subsidies #1709
Conversation
3bbb172
to
3855bdd
Compare
3855bdd
to
9ac6bf2
Compare
731d9de
to
a9f915a
Compare
a9f915a
to
c60b1b5
Compare
) | ||
|
||
enterprise_course_enrollment = models.OneToOneField( | ||
EnterpriseCourseEnrollment, | ||
blank=False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validation is done now to ensure either an enrollment or entitlement are present
c60b1b5
to
25ebd3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments to get started
07444cb
to
ed42ff1
Compare
e5f537e
to
0074bb1
Compare
2b711de
to
95d4cad
Compare
95d4cad
to
a101ac8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedback on the models to get started.
a5fda34
to
d73fccf
Compare
docs/decisions/0011-enterprise-subsidy-enrollments-and-entitlements.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0011-enterprise-subsidy-enrollments-and-entitlements.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0011-enterprise-subsidy-enrollments-and-entitlements.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0011-enterprise-subsidy-enrollments-and-entitlements.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0011-enterprise-subsidy-enrollments-and-entitlements.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0011-enterprise-subsidy-enrollments-and-entitlements.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0011-enterprise-subsidy-enrollments-and-entitlements.rst
Outdated
Show resolved
Hide resolved
33f3829
to
3907d68
Compare
docs/decisions/0011-enterprise-subsidy-enrollments-and-entitlements.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0011-enterprise-subsidy-enrollments-and-entitlements.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0011-enterprise-subsidy-enrollments-and-entitlements.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0011-enterprise-subsidy-enrollments-and-entitlements.rst
Outdated
Show resolved
Hide resolved
fe88f17
to
43120af
Compare
43120af
to
bdb4e16
Compare
Merge checklist:
requirements/*.txt
files)base.in
if needed in production but edx-platform doesn't install ittest-master.in
if edx-platform pins it, with a matching versionmake upgrade && make requirements
have been run to regenerate requirementsmake static
has been run to update webpack bundling if any static content was updated./manage.py makemigrations
has been run./manage.py lms makemigrations
in the shell.Post merge:
(so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
make upgrade
in edx-platform will look for the latest version in PyPi.