[ENT-8005]: Refactor learner data transmission audit record #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justEhmadSaeed
requested review from
zamanafzal,
sameenfatima78,
hamzawaleed01 and
MueezKhan246
justEhmadSaeed
force-pushed
the
asaeed/ENT-8005
branch
from
f44ede3
to
fe1db64
Compare
justEhmadSaeed
force-pushed
the
asaeed/ENT-8005
branch
from
13cd893
to
04eb42d
Compare
|
|
||
| return [ | ||
| BlackboardLearnerDataTransmissionAudit( | ||
| course_id = get_course_id_for_enrollment(enterprise_enrollment) |
There was a problem hiding this comment.
Have we confirmed if this reutrns a course key or course run key?
There was a problem hiding this comment.
The course run keys have already been removed. The existing code only returns course key.
sameenfatima78
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Looks good but should take a second opinion from @zamanafzal before merging.
zamanafzal
reviewed
Jan 3, 2024
| BlackboardLearnerDataTransmissionAudit( | ||
| course_id = get_course_id_for_enrollment(enterprise_enrollment) | ||
| # We only want to send one record per enrollment and course, so we check if one exists first. | ||
| learner_transmission_record = BlackboardLearnerDataTransmissionAudit.objects.filter( |
There was a problem hiding this comment.
How about using get_or_create instead of checking the record?
There was a problem hiding this comment.
The problem is that we're not creating the record at this point but creating its model instance. As far as I know, the get_or_create method creates the record in db. Correct me if I'm wrong because this method can make the code a lot cleaner.
zamanafzal
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: ENT-8005
Description:
Refactor learner data transmission audit records to utilize the updating record instead of creating a new one every time.
Note: Test cases for Canvas, blackboard, and Cornerstone are under progress.
Merge checklist:
requirements/*.txtfiles)base.inif needed in production but edx-platform doesn't install ittest-master.inif edx-platform pins it, with a matching versionmake upgrade && make requirementshave been run to regenerate requirementsmake statichas been run to update webpack bundling if any static content was updated./manage.py makemigrationshas been run./manage.py lms makemigrationsin the shell.Post merge:
(so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
make upgradein edx-platform will look for the latest version in PyPi.