feat: selectable students waiting step

[johnvente]

Description

This PR adds a toggable feature that allows instructors to automatically search a student after selecting it from the ORA waiting list table:

Here's what you see in the video explained:

• There's a student in the ORA waiting list after not receiving an assessment from their peers
• The instructor selects the Open Responses tab from the instructor dashboard
• The table shows the selectable column
• The instructor selects the number of students waiting for an assessment
• The instructor selects the student from the table
• A Search button appears
• The instructor presses the search button
• The information on the student's submission is shown
  Now the instructor can grade the student.

Why are we proposing these changes? This improvement makes it easier for the instructors to grade ORA submissions without copying and pasting each username for a manual search. As said before, this feature can be turned on and off in case you want the default ORA behavior.

How to test

• Create at least two students.
• Go to your course -> Create a new unit -> Create an open response component -> Peer Assessment.
• Then edit the open response -> Edit -> Assessment Steps.
  -> Select Step Peer Assessment option.
  Must Grade: 1
  Grade By: 1
• As students upload the open responses:
• Have student 1 fill out the open response and submit.
• Have student 2 fill out the open response, submit, and check student 1's open response.
• As an instructor, go to the Instructor panel ->Open Responses-> Waiting column.
• As an instructor, you can see the list of students. Select the one that you want to review and click on the Search Learner button.

DETAILED INSTRUCTIONS, WITH CONFIGURATIONS

You must enable these two features

FEATURES["ENABLE_XBLOCK_VIEW_ENDPOINT"] = True
FEATURES["ENABLE_ORA_SELECTABLE_LEARNER_WAITING_REVIEW"] = True

Here an example to add them in tutor:

from tutor import hooks

hooks.Filters.ENV_PATCHES.add_items(
    [
        (
            "openedx-lms-development-settings",
            """
FEATURES["ENABLE_XBLOCK_VIEW_ENDPOINT"] = True
FEATURES["ENABLE_ORA_SELECTABLE_LEARNER_WAITING_REVIEW"] = True

"""
        ),
    ]
)

Developer Checklist

• Reviewed the release process
• Translations and JS/SASS compiled
• Bumped version number in openassessment/__init__.py and package.json

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

• I've done a visual code review
• I've tested the new functionality

FYI: @openedx/content-aurora

[openedx-webhooks]

Thanks for the pull request, @johnvente! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[mariajgrimaldi]

I left a few comments for you to consider! Thanks

[johnvente]

I left a few comments for you to consider! Thanks

Hey @mariajgrimaldi! I've made the changes. Any additional suggestions I will be attentive to review them

[johnvente]

Hi @pomegranited! I've added the doc for the feature flag and updated the version. Please let me know if there is any changed needed it. Thanks a lot

[itsjeyd]

Hey @pomegranited, just checking in to see when you'd be able to complete another review pass here?

[pomegranited]

👍 This change works as described, thank you @johnvente :)

Could you merge latest master, fix the conflicts, and bump the version strings again? I can merge once that's done.

• I tested this on my devstack using the PR test instructions (which were fantastic 💯 )
• I read through the code
• I checked for accessibility issues by using my keyboard to navigate.
• Includes documentation of the added feature flag.
• User-facing strings are extracted for translation

[johnvente]

👍 This change works as described, thank you @johnvente :)

Could you merge latest master, fix the conflicts, and bump the version strings again? I can merge once that's done.

Hi @pomegranited Thanks for the review here we really appreciate it. I've solve conflicts and the comment that you mentioned here Now this is ready to be merged if there is any concern please let me know. Thanks a lot

[pomegranited]

Thank you so much @johnvente !

I found one teeny nit in a test file (sorry I missed this on my first pass!). But once that's fixed, I will merge.

• I tested this on my devstack with the new feature flag undefined in edx-platform, with the flag defined and False, and with the flag set to True.
• I read through the code
• I checked for accessibility issues by using my keyboard to navigate.
• Includes documentation
• User-facing strings are extracted for translation

[pomegranited]

Should be another assert here:

Suggested change

	json.loads(xblock_args_el[0].text)['CONTEXT']['selectable_learners_enabled'] = esg_flag_input
	assert json.loads(xblock_args_el[0].text)['CONTEXT']['selectable_learners_enabled'] == esg_flag_input

[johnvente]

@pomegranited Done!

[openedx-webhooks]

@johnvente 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.