Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add PII annotations to models #2252

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

bmtcril
Copy link
Contributor

@bmtcril bmtcril commented Nov 19, 2024

TL;DR -

Per OEP-30 these annotations should live with the models. This is just moving the existing edx-platform overrides to the correct location.

What changed?

  • Annotation added to model comments

Developer Checklist

I don't believe these changes merit a release on their own.

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

Per OEP-30 these annotations should live with the models. This is just
moving the existing edx-platform overrides to the correct location.
@bmtcril bmtcril requested a review from a team as a code owner November 19, 2024 18:03
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (e7eeb4c) to head (f205f78).
Report is 18 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2252   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files         195      195           
  Lines       21624    21624           
  Branches     1502     1502           
=======================================
  Hits        20606    20606           
  Misses        771      771           
  Partials      247      247           
Flag Coverage Δ
unittests 95.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmtcril
Copy link
Contributor Author

bmtcril commented Nov 19, 2024

FWIW there was a flaky 3.11 - js test, re-running the test cleared it.

@bmtcril
Copy link
Contributor Author

bmtcril commented Nov 22, 2024

@openedx/2u-aurora do any of you have time to review this quick PR?

@bmtcril bmtcril merged commit 5ce4156 into master Nov 26, 2024
11 checks passed
@bmtcril bmtcril deleted the bmtcril/pii_annotations branch November 26, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants