-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename aria-labeledby to aria-labelledby #2284
base: master
Are you sure you want to change the base?
rename aria-labeledby to aria-labelledby #2284
Conversation
Thanks for the pull request, @keithamus! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thank you for catching and fixing this @keithamus ! It's embarrassing how long this error has been in the code.
- I tested this by running this code in my tutor dev stack and checking that ORA2 blocks still author and render as expected.
- I read through the code changes and checked that aria-labelledby is the correct attribute to use instead of aria-labeledby
- I checked for accessibility issues by using my keyboard to navigate
-
Includes documentationN/A -
User-facing strings are extracted for translationN/A
TL;DR - Renames all uses of
aria-labeledby
toaria-labelledby
.I'm making this change because the
aria-labeledby
(with a singlel
in the middle) is the alternate spelling to the correctaria-labelledby
(with twol
s in the middle). The twol
s version is preferred over the singlel
version. Some browsers will only respect the version with twol
s.I discovered this repository by performing a code search for uses of
aria-labeledby
and sending PRs to replace them. (I'm not a bot but someone who is working on fixing this issue). For more on this you could read w3c/aria#2093.JIRA: (none)
What changed?
aria-labeledby
attributes have changed toaria-labelledby
.Developer Checklist
Testing Instructions
[ How should a reviewer test this PR? ]
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora