Add the UI Toolkit to edx-platform #11880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good 👍 |
|
@andy-armstrong 👍 Thanks. Did you have examples of how this gets added in places where RequireJS is not used? Are we saying RequireJS must be introduced and we'll need docs to that, or is there some shortcut that we are ok with? |
|
@robrap I haven't thought through the options for non-RequireJS pages. I'll merge this (once I have an updated UI Toolkit release to consume) and then I'll work on a separate PR solution. |
|
Sounds good. Thanks. |
andy-armstrong
force-pushed
the
andya/add-ui-toolkit-only
branch
from
db1fb64 to
c571941
Compare
andy-armstrong
force-pushed
the
andya/add-ui-toolkit-only
branch
from
c571941 to
0177eed
Compare
andy-armstrong
added a commit
that referenced
this pull request
Mar 22, 2016
Add the UI Toolkit to edx-platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UITK-75
This adds the UI Toolkit to edx-platform, and then makes a single change to use the new HtmlUtils class. The intention is that this is a simpler PR to land before tomorrow's marathon, and that the original PR (https://github.com/edx/edx-platform/pull/11856) will be rebased on top of this.
In addition, the static path for the Pattern Library has been made
/static/edx-pattern-libraryinstead of just/static/pattern-library. This change was already made in the Pattern Library so it was made here too for consistency.Sandbox
Testing
Reviewers
If you've been tagged for review, please check your corresponding box once you've given the 👍.
FYI: @cahrens @dan-f @dsjen @bjacobel
Post-review