Skip to content

Conversation

@oliviermarquez
Copy link
Contributor

fixes tab buttons of student's dahsboard for i18n - replace pr #757

fixes tab buttons of student's dahsboard for i18n
@singingwolfboy
Copy link
Contributor

Gah, I'm sorry we left this pull request untouched for so long. :( In order to merge it, we'll need to you sign an individual contributor agreement, as documented in the CONTRIBUTING file in the repository.

@oliviermarquez
Copy link
Contributor Author

sent.

such a pity that the term AGPL is not mentioned in any way on this
contributor agreement.

2013/10/17 David Baumgold notifications@github.com

Gah, I'm sorry we left this pull request untouched for so long. :( In
order to merge it, we'll need to you sign an individual contributor
agreement http://code.edx.org/individual-contributor-agreement.pdf, as
documented in the CONTRIBUTINGhttps://github.com/edx/edx-platform/blob/master/CONTRIBUTING.mdfile in the repository.


Reply to this email directly or view it on GitHubhttps://github.com/edx/edx-platform/pull/1234#issuecomment-26538433
.

@jtauber
Copy link
Contributor

jtauber commented Oct 18, 2013

Contributor agreement received.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have an extra comma in this line that is causing a SyntaxError in the unit tests.

@singingwolfboy
Copy link
Contributor

Once we get the tests passing (remove the extra comma), this is ready to merge. It would be nice if you could also add yourself to the AUTHORS file in the repository.

@sarina
Copy link
Contributor

sarina commented Oct 24, 2013

Hi @oliviermarquez - could you please rebase your branch on master? Your branch has some conflicts that need to be resolved, as well as a failing test that is not due to your code changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conventionally, we like the final closing brace to appear at the same indentation level as the first line (so at the same indentation level of course.tabs - an indent of only 4, not 8, spaces in this case).

@oliviermarquez oliviermarquez mentioned this pull request Oct 24, 2013
@oliviermarquez
Copy link
Contributor Author

Done in pr #1489

@oliviermarquez oliviermarquez deleted the patch-2 branch October 24, 2013 19:35
@oliviermarquez oliviermarquez mentioned this pull request Oct 25, 2013
@sarina sarina mentioned this pull request Oct 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants