-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Update tabs.py #1489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tabs.py #1489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove +
|
Looks good to me. @adampalay can you take a look too? @oliviermarquez I'll run the test suite on your code once you remove the syntax error. |
|
Yeah, once you remove the |
|
@oliviermarquez please make another comment on this PR when you fix the issue, so I know to take another look at the PR. Thanks! |
|
Please squash your commits into one commit by running this command:
Check out https://help.github.com/articles/interactive-rebase for more help. Once you've done this please comment on the PR. |
|
-> PR #1507 |
|
We'd really prefer you simply rebase and stay on the same pull request, because closing a request and opening a new one loses the comment and review history. In the future please do this. Ask on the IRC channel or the edx email list if you need help with rebasing. |
|
Also, you can make comments on the pull request to ask for help. |
fixes tab buttons of student's dahsboard for i18n - replace pr #1234 and pr #757