Update tabs.py#1489
Update tabs.py#1489oliviermarquez wants to merge 3 commits intoopenedx:masterfrom oliviermarquez:patch-3
Conversation
|
Looks good to me. @adampalay can you take a look too? @oliviermarquez I'll run the test suite on your code once you remove the syntax error. |
|
Yeah, once you remove the |
|
@oliviermarquez please make another comment on this PR when you fix the issue, so I know to take another look at the PR. Thanks! |
|
Please squash your commits into one commit by running this command:
Check out https://help.github.com/articles/interactive-rebase for more help. Once you've done this please comment on the PR. |
|
-> PR #1507 |
|
We'd really prefer you simply rebase and stay on the same pull request, because closing a request and opening a new one loses the comment and review history. In the future please do this. Ask on the IRC channel or the edx email list if you need help with rebasing. |
|
Also, you can make comments on the pull request to ask for help. |
fixes tab buttons of student's dahsboard for i18n - replace pr #1234 and pr #757