Skip to content

Update tabs.py#1489

Closed
oliviermarquez wants to merge 3 commits intoopenedx:masterfrom
oliviermarquez:patch-3
Closed

Update tabs.py#1489
oliviermarquez wants to merge 3 commits intoopenedx:masterfrom
oliviermarquez:patch-3

Conversation

@oliviermarquez
Copy link
Contributor

fixes tab buttons of student's dahsboard for i18n - replace pr #1234 and pr #757

@oliviermarquez oliviermarquez mentioned this pull request Oct 24, 2013
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove +

@sarina
Copy link
Contributor

sarina commented Oct 24, 2013

Looks good to me. @adampalay can you take a look too?

@oliviermarquez I'll run the test suite on your code once you remove the syntax error.

@adampalay
Copy link
Contributor

Yeah, once you remove the +s, it looks great

@sarina
Copy link
Contributor

sarina commented Oct 24, 2013

@oliviermarquez please make another comment on this PR when you fix the issue, so I know to take another look at the PR. Thanks!

@sarina
Copy link
Contributor

sarina commented Oct 25, 2013

Please squash your commits into one commit by running this command:

$ git rebase -i HEAD~3

Check out https://help.github.com/articles/interactive-rebase for more help. Once you've done this please comment on the PR.

@oliviermarquez
Copy link
Contributor Author

-> PR #1507

@oliviermarquez oliviermarquez deleted the patch-3 branch October 25, 2013 21:06
@sarina
Copy link
Contributor

sarina commented Oct 25, 2013

We'd really prefer you simply rebase and stay on the same pull request, because closing a request and opening a new one loses the comment and review history. In the future please do this. Ask on the IRC channel or the edx email list if you need help with rebasing.

@sarina
Copy link
Contributor

sarina commented Oct 25, 2013

Also, you can make comments on the pull request to ask for help.

@sarina sarina mentioned this pull request Oct 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants