-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Make "Delete My Account" text configurable #19779
Proposal: Make "Delete My Account" text configurable #19779
Conversation
Thanks for the pull request, @pkulkark! I've created OSPR-3065 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here. |
I'm not sure I understand what's being proposed specifically. OEP-0028 is a big proposal, and I'm not up to speed on it's current status. The short term solution sounds like it wouldn't really require any code changes to edx-platform itself, if existing comprehensive theming overrides will work (though I agree that it's not ideal)? |
@ormsbee Sorry for the delayed response. Basically, we're asking if we can make the |
@pkulkark: Yes, go ahead and make FWIW, I'm guessing this template will be in Juniper, and we can make a good migration argument for leaving it in that release. However, it's almost certain to be gone before Koa. |
Since we've discussed this and you have approval for a path forward, I'm going to close this PR. Please feel free to open a new one with the implementation, or re-open this one if that's more convenient. |
@pkulkark Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
We want to make the text appearing in the "Delete My Account" section of the Account Settings page, configurable via comprehensive themes. Currently the text shown in this section is quite specific to edx.org:
Proposed solution
The above text is defined within the
StudentAccountDeletion
react component. This component is rendered from theStudentAccountDeletionInitializer.js
file. Javascript files can be overridden in themes but in this particular case, theaccount_settings.html
loadsStudentAccountDeletionInitializer
as a webpack entry-point. There are two ways to go about this:The short-term solution would be to redefine
account_settings.html
file within the custom theme, which can contain the customized text written in html.The long-term solution would be to implement theming of react component. There is already an OEP for this that covers the details.
CC: @natabene