Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Make "Delete My Account" text configurable #19779

Conversation

pkulkark
Copy link
Contributor

We want to make the text appearing in the "Delete My Account" section of the Account Settings page, configurable via comprehensive themes. Currently the text shown in this section is quite specific to edx.org:

Please note: Deletion of your account and personal data is permanent and cannot be undone. EdX will not be able to recover your account or the data that is deleted.

Once your account is deleted, you cannot use it to take courses on the edX app, edx.org, or any other site hosted by edX. This includes access to edx.org from your employer’s or university’s system and access to private sites offered by MIT Open Learning, Wharton Executive Education, and Harvard Medical School.

You may also lose access to verified certificates and other program credentials like MicroMasters certificates. If you want to make a copy of these for your records before proceeding with deletion, follow the instructions for printing or downloading a certificate.

Proposed solution

The above text is defined within the StudentAccountDeletion react component. This component is rendered from the StudentAccountDeletionInitializer.js file. Javascript files can be overridden in themes but in this particular case, the account_settings.html loads StudentAccountDeletionInitializer as a webpack entry-point. There are two ways to go about this:

  1. The short-term solution would be to redefine account_settings.html file within the custom theme, which can contain the customized text written in html.

  2. The long-term solution would be to implement theming of react component. There is already an OEP for this that covers the details.

CC: @natabene

@openedx-webhooks
Copy link

Thanks for the pull request, @pkulkark! I've created OSPR-3065 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Feb 11, 2019
@natabene
Copy link
Contributor

@pkulkark Thank you for your contribution. @ormsbee Do you want to give this an early look?

@openedx-webhooks openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs triage labels Feb 11, 2019
@ormsbee
Copy link
Contributor

ormsbee commented Feb 12, 2019

I'm not sure I understand what's being proposed specifically. OEP-0028 is a big proposal, and I'm not up to speed on it's current status. The short term solution sounds like it wouldn't really require any code changes to edx-platform itself, if existing comprehensive theming overrides will work (though I agree that it's not ideal)?

@pkulkark
Copy link
Contributor Author

@ormsbee Sorry for the delayed response. Basically, we're asking if we can make the account_settings.html page themeable, because it currently isn't, even though it contradicts the long-term plans.

@ormsbee
Copy link
Contributor

ormsbee commented Feb 28, 2019

@pkulkark: Yes, go ahead and make account_settings.html themable. My understanding is that it'll be fairly straightforward to do so. If there are complicating factors, please let me know.

FWIW, I'm guessing this template will be in Juniper, and we can make a good migration argument for leaving it in that release. However, it's almost certain to be gone before Koa.

@ormsbee
Copy link
Contributor

ormsbee commented Mar 11, 2019

Since we've discussed this and you have approval for a path forward, I'm going to close this PR. Please feel free to open a new one with the implementation, or re-open this one if that's more convenient.

@ormsbee ormsbee closed this Mar 11, 2019
@openedx-webhooks
Copy link

@pkulkark Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@openedx-webhooks openedx-webhooks added rejected and removed engineering review waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Jan 22, 2021
@bradenmacdonald bradenmacdonald deleted the pooja/proposal-configurable-delete-account-text branch January 12, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U rejected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants