XBlock Xml Serialization/Deserialization #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs https://github.com/edx/XBlock/pull/161 before it can be merged. |
|
@cpennington the build keeps flat-out failing. I think Jenkins prevents you from requiring something from your own repo, but I'm not entirely certain: https://jenkins.testeng.edx.org/job/edx-all-tests-manual-pr/523/SHARD=1,TEST_SUITE=unit/console |
|
I borked the requirements file line. Fixed, and pushed. |
| child, system) | ||
| child, | ||
| system | ||
| ) |
There was a problem hiding this comment.
This didn't fit on one line?
|
Address these comments, then 👍 |
| @@ -81,12 +81,10 @@ def get_html(self): | |||
|
|
|||
| @classmethod | |||
| def _construct(cls, system, contents, error_msg, location): | |||
| location = Location(location) | |||
|
Need to import |
|
LGTM after comments addressed 👍 |
|
👍 again after reviewing the test changes. |
XModules continue to use their own interface for xml, but provide an adaptor that makes the the XBlock interface available. [LMS-179]
cpennington
added a commit
that referenced
this pull request
Jan 14, 2014
XBlock Xml Serialization/Deserialization
cpennington
added a commit
to cpennington/edx-platform
that referenced
this pull request
Jan 15, 2014
cpennington
added a commit
that referenced
this pull request
Jan 29, 2014
Fix pylint violations from #2129
zubair-arbi
pushed a commit
to zubair-arbi/edx-platform
that referenced
this pull request
Jan 29, 2014
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Sep 7, 2017
* addition of test code of the certificate issuance function openedx#2038 (openedx#2054) * Mod translation of 'Course End Date:' openedx#2084 (openedx#2090) * Add menu to ga_operation for ga_analyzer openedx#2039 (openedx#2088) * Fixed bugs openedx#2039 (openedx#2112) * Fixed csv format openedx#2039 (openedx#2127) * Change to split download if there are many display items openedx#916 (openedx#2121) * Change to split download if there are many display items openedx#916 * Fix UT * Fix Review * Fix review2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.