Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Rename values in SiteConfiguration (2/3) attempt #2"" (attempt #3) #23306

Conversation

pwnage101
Copy link
Contributor

@pwnage101 pwnage101 commented Mar 4, 2020

This reverts commit e6f58b6.

This is our third (3rd!) attempt to deploy stage 2 of this column rename.


Just as a quick reminder for reviewers, this PR does the following things:

  • Removes all code references to the old field.
  • Does NOT include a migration to remove the field, hence adding a @skip to the unit test that checks that migrations are in sync (test_migrations_are_in_sync).
  • Adds a new feature to the SiteConfiguration model: the ability to save() without triggering a history record. I also added unit tests for this new feature.
  • Adds a data migration to backfill both SiteConfiguration and SiteConfigurationHistory. Specifically made sure to skip triggering history while backfilling SiteConfiguration.

@pwnage101 pwnage101 requested review from a team March 4, 2020 17:46
@pwnage101 pwnage101 requested a review from a team as a code owner March 4, 2020 17:46
@pwnage101 pwnage101 requested a review from a team March 4, 2020 17:46
@pwnage101 pwnage101 changed the title Revert "Revert "Rename values in SiteConfiguration (2/3) attempt #2"" Revert "Revert "Rename values in SiteConfiguration (2/3) attempt #2"" (attempt #3) Mar 4, 2020
Copy link
Contributor

@doctoryes doctoryes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roll the 🎲 🎲 !

@pwnage101 pwnage101 force-pushed the pwnage101/deng-18-rename_site_configuration_siteconfiguration_values_2.3 branch from aee9d74 to a18ece1 Compare March 4, 2020 18:48
This reverts commit e6f58b6.

This is our third (3rd!) attempt to deploy stage 2 of this column rename.
@pwnage101 pwnage101 force-pushed the pwnage101/deng-18-rename_site_configuration_siteconfiguration_values_2.3 branch from a18ece1 to d428f75 Compare March 4, 2020 19:53
@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants