Provide logo URL from the backend #25994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins run js |
|
jenkins run quality |
awaisdar001
requested review from
saadyousafarbi,
AhtishamShahid and
asadazam93
|
Your PR has finished running tests. There were no failures. |
asadazam93
approved these changes
Jan 8, 2021
AhtishamShahid
approved these changes
Jan 22, 2021
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/deploy_to_stage |
|
EdX Release Notice: This PR has been deployed to the production environment. |
mudassir-hafeez
added a commit
to mudassir-hafeez/edx-platform
that referenced
this pull request
Jul 18, 2024
mudassir-hafeez
added a commit
to mudassir-hafeez/edx-platform
that referenced
this pull request
Jul 19, 2024
mudassir-hafeez
added a commit
to mudassir-hafeez/edx-platform
that referenced
this pull request
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide Email Logo URL from Backend
This PR adds a new method in the branding API which would be used to serve a logo URL from embedding into emails. This method is used in Bulk Email and edX ACE emails.
Once that is merged, the base template in Django admin needs to use the context variable
logo_url.TNL-7872