fix: course creation notice visibility and admin search #28735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a JS bug that made it so the course creation rights notice (the thing that invites new studio users to request access to create content) disappeared if the user selected the "Courses" or "Libraries" tab. This is because it was incorrectly comparing the #courses-tab URL frament against the string "courses" instead of "courses-tab". TNL-8718
It was broken because "organizations" was erronously included in the `search_fields` admin option. Many-to-many fields may not be used for search. TNL-8722
kdmccormick
changed the title
kenclary
approved these changes
Sep 14, 2021
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
Your PR has finished running tests. There were no failures. |
farhaanbukhsh
added a commit
to open-craft/edx-platform
that referenced
this pull request
Oct 4, 2021
Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes two bugfixes. They are separate, but related in that they touch the "course_creators" CMS app.
The second commit (admin search) fixes a bug introduced by this community PR: https://github.com/edx/edx-platform/pull/26616. The first commit (creation rights notice) fixes a bug that was reported right around the same time, although I cannot find any code-level evidence that it is related to the community PR.
fix: show creation rights notice on studio "courses" tab
There was a JS bug that made it so the course creation rights
notice (the thing that invites new studio users to request
access to create content) disappeared if the user selected
the "Courses" or "Libraries" tab.
This is because it was incorrectly comparing the #courses-tab
URL frament against the string "courses" instead of "courses-tab".
Home page (with or without fix):
After clicking "Courses" tab (without fix):
After clicking "Courses" tab (with fix):
fix: repair search of course creator statuses in django admin
It was broken because "organizations" was erronously included
in the
search_fieldsadmin option. Many-to-many fieldsmay not be used for search.
Supporting information
Bug tix:
Testing instructions
Creation notice visibility:
Repro bug:
#courses-tabto the URL.Confirm fix:
#courses-tabto the URL.Admin search:
Repro bug:
Confirm fix:
Deadline
For partner support's sake, would be good to have this in by end-of-week (2021-09-17).
Other information
None