-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Studio - Help Links Addition and Small UI Revisions to Main Navigation #299
Conversation
@frrrances, @marcotuts, and @markchang - mind reviewing/testing this before merging? |
👍 looks great! my only comment/thought was that some of the dropdowns felt wider than they needed to be, though I understand they were likely synced to the ones near them to have consistent sizing. More specifically, the Content and Tools dropdowns are sized to match the Settings width (I think) and the Profile dropdown is also wider. |
I just came across a few small things that need tweaking:
|
Thanks, @frrrances and @marcotuts. I've made a few tweaks:
@marcotuts all of the dropdown menus have a fixed width, I just customized it for the help dropdown since the titles were forced to two lines. Rather than customize for each one, I'm fine with leaving them mostly consistent if you are. |
Also, some other things to note:
@markchang, feel free to chime in on these, especially #2 since it causes an app-wide change. |
I think it makes sense to move to a single edX blue, am ok with the width staying the same on the menus, and all other changes made sense to me. 👍 |
Thanks for the comments here and in-person, @marcotuts and @frrrances. @frrrances, I think I resolved all of the layout issues you brought up (wrapped the two sides of the nav in wrappers and floated them). Would you mind taking one more spin through and checking things out? @markchang mind reviewing this and giving approval before I merge? |
nice work, brian. just one last thing... I think the user nav is stacking on small screen for me because my name is 12 characters long. maybe we should put a max-width on that as well? and/or bump down the spacing between nav items to accomodate more characters. |
@frrrances, thanks for the continued proofing - I think I've got the long username case covered now (truncating with ellipses in browsers that support that). Sadly, the only other thing I can do is bump down the font size (currently at 16rem vs. 14rem, what our current Studio nav is displayed at). Let me know what you think and thanks again. |
@markchang thanks for all of the comments. I've addressed all of them:
Let me know if there's anything else I should address before rolling this in. |
Thumbsup. |
Studio - Help Links Addition and Small UI Revisions to Main Navigation
…e-clean-xblockid mattdrayer/api-groupprofile-clean-xblockid: Migrate transitional content...
This PR covers the following things: