Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-14] feat: implement V2 libraries usage for library content block #30895

Conversation

dyudyunov
Copy link
Contributor

IMPORTANT!
This PR requires the openedx-unsupported/blockstore#197 to be merged first.

This PR consists of:

This will close Milestone 4.0b

  • V2 libraries are available for selection in the Random Block edit modal;
  • selected V2 library blocks are copied to the modulestore and saved as children of the Random Block;
  • V2 library version validation works the same as for the V1 libraries (with a possibility to update the block with the latest version).
  • filtering by problem type can't be done for V2 the same as for V1 because the v2 library problems are not divided by types. Selecting a problem type filter in the edit mode using the V2 library will not have any effect;
  • unit tests added/updated.

Note: I didn’t add any additional permission checks for getting libraries, only reused current functionality (as we’ve discussed earlier). If the permission checks need any updates - it will be done as a separate task (to avoid blocking several tasks dependent on this one)

YT: https://youtrack.raccoongang.com/issue/EDX_BLND_CLI-87

- V2 libraries are available for selection in the Random Block edit modal;
- selected V2 library blocks are copied to the modulestore and saved as children of the Random Block;
- V2 library version validation works the same as for the V1 libraries (with possibility to update block with the latest version);
- filtering by problem type can't be done for V2 the same as for V1 because the v2 library problems are not divided by types;
- the problem type field is hidden for v2 libraries in the edit mode;
- unit tests added/updated.
@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Aug 24, 2022
@openedx-webhooks
Copy link

openedx-webhooks commented Aug 24, 2022

Thanks for the pull request, @dyudyunov!

When this pull request is ready, tag your edX technical lead.

@dyudyunov dyudyunov changed the title [BD-14] feat: implement V2 libraries usage for library content block [WIP][BD-14] feat: implement V2 libraries usage for library content block Aug 24, 2022
There could be a lot of bundles, so we can't use query params
because it will raise the "Request-URI Too Long" error. Use the
request data in such case.
@dyudyunov dyudyunov force-pushed the update-library-content-block-to-use-v2-libs branch from fc0f248 to c941170 Compare August 26, 2022 15:00
@dyudyunov dyudyunov changed the title [WIP][BD-14] feat: implement V2 libraries usage for library content block [BD-14] feat: implement V2 libraries usage for library content block Aug 26, 2022
@mphilbrick211
Copy link

@dyudyunov looks like this needs branch conflicts resolved before merging.

Hi @connorhaugh - flagging for you as author is requesting an update.

@dyudyunov
Copy link
Contributor Author

BD-14 project was closed in the RG and all additional work should be scheduled with our PMs

@kdmccormick
Copy link
Member

Closing in favor of #33263

@kdmccormick kdmccormick closed this Oct 6, 2023
@openedx-webhooks
Copy link

@dyudyunov Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

1 similar comment
@openedx-webhooks
Copy link

@dyudyunov Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@dyudyunov dyudyunov deleted the update-library-content-block-to-use-v2-libs branch October 9, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants