Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow for forcing asymmetric jwts #32045

Merged
merged 4 commits into from
Apr 10, 2023
Merged

feat: allow for forcing asymmetric jwts #32045

merged 4 commits into from
Apr 10, 2023

Conversation

robrap
Copy link
Contributor

@robrap robrap commented Apr 10, 2023

Description

Add a temporary feature toggle to force the LMS to only produce asymmetric JWTs. This is a part of
DEPR of Symmetric JWTs:
openedx/public-engineering#83

@davidjoy
Copy link
Contributor

Assuming we believe it's okay for create_jwt_for_user to call _create_jwt with use_asymmetric_key=False and that changing the behavior here won't break something trying to use that JWT, then this looks good.

@robrap
Copy link
Contributor Author

robrap commented Apr 10, 2023

Assuming we believe it's okay for create_jwt_for_user to call _create_jwt with use_asymmetric_key=False and that changing the behavior here won't break something trying to use that JWT, then this looks good.

Yes. This will be ok as long as all the consumers can handle the asymmetric JWTs, and I am working on confirming that.

robrap added 4 commits April 10, 2023 14:19
@robrap
feat: allow for forcing asymmetric jwts
f7c9167 
Add a temporary feature toggle to force the LMS to
only produce asymmetric JWTs. This is a part of
DEPR of Symmetric JWTs:
openedx/public-engineering#83
@robrap
fixup! update name
1091e36
@robrap
fixup! fix typo
0122bee
@robrap
fixup! use real if
820de19
@robrap robrap force-pushed the robrap/force-asymmetric-jwts branch from 82be1e1 to 820de19 Compare April 10, 2023 18:19
@robrap robrap merged commit 6cae1fa into master Apr 10, 2023
@robrap robrap deleted the robrap/force-asymmetric-jwts branch April 10, 2023 18:46
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@robrap robrap mentioned this pull request Apr 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmc-edx timmc-edx timmc-edx approved these changes

@davidjoy davidjoy davidjoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robrap @davidjoy @edx-pipeline-bot @timmc-edx