fix: Added feature toggle check for account deletion API (#32846)

[kiran1415]

Description

Based on this forum discussion, I have incorporated support for a check feature toggle/flag (FEATURES["ENABLE_ACCOUNT_DELETION"]) in the account deletion API.

Useful information to include:
NA

Supporting information

wg-test-relese-discussion

Testing instructions

Please disable the "ENABLE_ACCOUNT_DELETION" feature flag and attempt to delete your account. You should receive a forbidden.

Deadline

NA

Other information

NA

[openedx-webhooks]

Thanks for the pull request, @kiran1415! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[e0d]

@kiran1415 Looks like the quality check is failing, can you have a look?

[kiran1415]

@e0d I have added a fix to pass the quality pass check

[mphilbrick211]

Hi @openedx/2u-aperture! Is this something you could review/merge for us? Thanks!

[mphilbrick211]

Hi @openedx/2u-aperture! This is ready for review - would someone be able to enable the tests again? Thanks!

[e0d]

@kiran1415 Looks like there are some failed checks, can you have a look?

[mphilbrick211]

Hi @openedx/2u-aperture! This is ready for review. Thanks!

[robrap]

@kiran1415: [request] Thanks for this. I'm not planning on doing a detailed review, but could you add a unit test?

@mphilbrick211: [inform] This was tagged as arch-bom on the Contributions board, so I have updated to Aurora.

[jsnwesson]

Hi @mphilbrick211 and @robrap , I'm just seeing this PR while on-call and I'm seeing that my team (Aperture) is being asked for review but this is on Aurora's Contribution board. Does this mean that Aperture is still responsible for review or should this be on Aurora?
Secondly, for any OSPRs needed to be reviewed by Aperture, it'd be appreciated if the label needs maintainer attention could be added. It's the surest way that any on-call engineer will see a PR and triage it for review. Thanks!

[robrap]

@jsnwesson:

1. I made a mistake tagging "Aurora". Your teams both start with "A". 😉 I have fixed this and moved it to "Aperture".
2. I think the current process would be anything that has waiting for eng review label on your board to have your attention, which should also be in the Ready for Review column. Could that work for your team?

Note: We want to avoid different processes for different teams if it is different for different sake. That said, if there are things you can do with your proposed process that aren't possible with the current process, let's discuss with @mphilbrick211. Thank you!

[openedx-webhooks]

@kiran1415 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX production environment.

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX production environment.