Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support V2 libraries in LibraryContentBlock (randomized only) #33258

Closed

Conversation

kdmccormick
Copy link
Member

@kdmccormick kdmccormick commented Sep 14, 2023

Author credit to @connorhaugh and RaccoonGang. I just did the rebase and squash.

This also contains the commit from:

To see just the new changes, see the second commit.

Rather than implementing V2-library and static-library-reference support
in a new block, we will be enhancing the existing `LibraryContentBlock`
in-place.

Relevant ADR PR: openedx#33231
@@ -471,6 +471,11 @@ def public_view(self, context):
return self._student_or_public_view(context or {}, prereq_met, prereq_meta_info, None, PUBLIC_VIEW)

def author_view(self, context): # lint-amnesty, pylint: disable=missing-function-docstring
print('@@@@@@@@@@@@@@@@@@@@@@@@@@@')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: remind myself to get rid of this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #33263

@kdmccormick kdmccormick deleted the kdmccormick/library-content-v2 branch September 14, 2023 21:56
@kdmccormick
Copy link
Member Author

Closed in favor of #33263, which has a branch in the upstream repo so @connorhaugh can push to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants