fix: Open Responses Styling and Layout #33717
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @tspring5000! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
Hi @tspring5000! Thanks for this contribution! Please let me know if you have any questions regarding submitting a CLA form. |
mphilbrick211
added
the
needs test run
Thanks! Yeh just waiting for the docusign form now, will sign it as soon as I see it |
|
That should be signed now |
|
@tspring5000 |
tspring5000
force-pushed
the
open-responses-table-style
branch
from
1373238 to
4ec7913
Compare
e0d
removed
the
needs test run
Apologies about that, fixed now |
|
Ah, sorry, looks like I still have issues with my type labelling |
Ref: openedx/wg-build-test-release#223 The Open Responses tab on instructor dashboard on LMS has a few issues with table styling; there isn't enough spacing between some columns which makes the text difficult to read, and the bottom of some numbers in the summary table are cutoff This change adds padding to the right of each column to ensure longer text is still legible and changes the line height from 1em to 1 (unitless), which looks the same but doesn't cut off the bottom
Remove extra whitespace line 1862 for better formatting
tspring5000
force-pushed
the
open-responses-table-style
branch
from
d5d1405 to
3f8c509
Compare
mphilbrick211
added
needs test run
There was a problem hiding this comment.
Hi @tspring5000 thank you for contributing! Your change works great, so I'll merge this tomorrow.
👍
- I tested this on my devstack.
- I read through the code
- I checked for accessibility issues by using my keyboard to navigate.
-
Includes documentationN/A -
User-facing strings are extracted for translationN/A
|
@tspring5000 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
Thank you for your contribution @tspring5000 ! |
* fix: table styling on Instructor Dashboard Ref: openedx/wg-build-test-release#223 The Open Responses tab on instructor dashboard on LMS has a few issues with table styling; there isn't enough spacing between some columns which makes the text difficult to read, and the bottom of some numbers in the summary table are cutoff This change adds padding to the right of each column to ensure longer text is still legible and changes the line height from 1em to 1 (unitless), which looks the same but doesn't cut off the bottom * fix: remove whitespace Remove extra whitespace line 1862 for better formatting
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
This reverts commit 1dab744.
Description
The Open Responses tab on instructor dashboard on LMS has a few issues with table styling; there isn't enough spacing between some columns which makes the text difficult to read, and the bottom of some numbers in the summary table are cutoff.
This change adds padding to the right of each column to ensure longer text is still legible and changes the line height from 1em to 1 (unitless), which maintains the same style but doesn't cut off the bottom.
Supporting information
Fix for this ticket: openedx/wg-build-test-release#223
Testing instructions
LMS > View Course > Instructor tab > Open Responses
Other information
Old:
New:
