revert: feat: Added XblockMixin for skill tagging #34394
Closed
+41
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT -- This is blocked by #34231.
Description
This reverts commit 0b7e273 , added in:
We remove SkillTaggingMixin from common.py's XBLOCK_MIXINS because:
Skill tagging did not go through product review, so its code should
not be referenced in a core repository like edx-platform.
The skill_tagging package is not a listed dependency of
edx-platform, so it should not be referenced in edx-platform,
regardless of whether it technically can be imported using a
try-except clause.
Adding new classes to XBLOCK_MIXINS is strongly discouraged
(although, to be fair, this guidance did not exist when
SkillTaggingMixin was added; it was SkillTaggingMixin that made
us realize we needed to add the guidance).
Migration steps for operators
Fortunately, the XBLOCK_EXTRA_MIXINS Django setting exists for
this exact purpose. Site operators who wish to use skill tagging
can do so with these steps.
'skill_tagging.skill_tagging_mixin.SkillTaggingMixin'
Merge deadline
We will merge this on Tuesday April 16th so that it is fixed before the Redwood cut.
2U devs -- please apply the migration steps to your internal settings and verify ahead of that date. Let us know if you need any help or clarification! We can also merge on an earlier date if that's better--let us know when you're ready.