Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: course about page markup and styles improvements #34892

Conversation

ihor-romaniuk
Copy link
Contributor

Similar PR is opened to the open-release/palm branch:

Description

There are some fixes for the course about page:

  • display a course short description in course about heading-group (if necessary)
  • removing duplicated pre-requisite info in right sidebar
  • code formatting for the block % if get_course_about_section(request, course, "prerequisites"):

Fixes were also made to the _course_about.scss styles, to fix responsive layout of the course about header element.

Before fixes:

image

After fixes:

image

@openedx-webhooks
Copy link

openedx-webhooks commented Jun 3, 2024

Thanks for the pull request, @ihor-romaniuk!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 3, 2024
@ihor-romaniuk ihor-romaniuk changed the title Feat/master/course about page markup redwood feat: course about page markup and styles improvements Jun 3, 2024
@ihor-romaniuk ihor-romaniuk added the backport PR backports a change from main to a named release. label Jun 3, 2024
@mphilbrick211 mphilbrick211 added the product review PR requires product review before merging label Jun 5, 2024
@mphilbrick211 mphilbrick211 added product review complete PR has gone through product review and removed product review PR requires product review before merging labels Jul 31, 2024
@ihor-romaniuk ihor-romaniuk force-pushed the feat/master/course-about-page-markup-redwood branch from 7693c24 to 53f2ec2 Compare September 3, 2024 15:19
@mariajgrimaldi mariajgrimaldi merged commit 5ea3b98 into openedx:open-release/redwood.master Sep 9, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U product review complete PR has gone through product review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants