fix: correctly handles the enabling of submit button on reset

[imasdekar]

• disables the submit button on the click of reset button except for the cases when there is a gentle alert notification.

closes openedx/frontend-app-learning#1406
closes openedx/wg-build-test-release#362

Signed-off by: Ishan Masdekar imasdekar@disroot.org

[openedx-webhooks]

Thanks for the pull request, @imasdekar!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[e0d]

Your branch is behind the base. I've pulled in changes from master as a merge commit which will update your branch and cause the tests to be re-run.

[imasdekar]

@mariajgrimaldi this is resolving the openedx/frontend-app-learning#1406
can you please review this?

[imasdekar]

@e0d @mphilbrick211 can you please review this or ask an appropriate person to review it?

[mphilbrick211]

Hi @imasdekar! Thanks for your patience. We have this out to the community for review.

[mariajgrimaldi]

Hi @imasdekar, thanks again for the contribution! However, I can't see how this solution solves openedx/frontend-app-learning#1406 since the changes introduced by this PR impact only the learning legacy view, which is different from the Learning MFE https://github.com/openedx/frontend-app-learning. Am I missing something? Let me know!

[imasdekar]

@mariajgrimaldi As far as I understand the problem block is rendered in an iframe in frontend-app-learning so I implemented the fix here. Let me know if that is not the case.

[mariajgrimaldi]

@imasdekar: you're absolutely right. I'm sorry, I got it all mixed up :)

I'll be reviewing this soon, thank you again!