-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix: update openedx-learning to fix a bug where deleted containers were returned on the get_containers API method [FC-0083]
#36630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @rpenido! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-learning to fix a bug where deleted containers were returned on the get_containers API method [FC-0083]
|
I tested, confirmed it's working, and released a new openedx-learning version with the changes. Please update this PR and I can merge. |
a30d786 to
a21b569
Compare
openedx-learning to fix a bug where deleted containers were returned on the get_containers API method [FC-0083]openedx-learning to fix a bug where deleted containers were returned on the get_containers API method [FC-0083]
bradenmacdonald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rpenido Is this safe to merge? It's still marked as a draft.
Now it is! Was just testing again after updating the dependencies. |
a21b569 to
70deae5
Compare
|
@bradenmacdonald Someone needs to create the |
|
@rpenido It's now called |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
This PR updates the
openedx-learningpackage, fixing a bug where deleted containers were returned on theget_containersAPI method.Additional Information
Testing Instructions
tutor dev run cms python manage.py cms reindex_studio --experimentalPrivate ref: FAL-4144