Skip to content

Conversation

@rpenido
Copy link
Contributor

@rpenido rpenido commented Apr 29, 2025

Description

This PR updates the openedx-learning package, fixing a bug where deleted containers were returned on the get_containers API method.

Additional Information

Testing Instructions

  • Create a new library
  • Add a new unit to it
  • Delete the unit
  • Run tutor dev run cms python manage.py cms reindex_studio --experimental
  • Reload the library and check that the library is empty

Private ref: FAL-4144

@openedx-webhooks
Copy link

openedx-webhooks commented Apr 29, 2025

Thanks for the pull request, @rpenido!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 29, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Apr 29, 2025
@rpenido rpenido changed the title chore: upgrade openedx-learning fix: update openedx-learning to fix a bug where deleted containers were returned on the get_containers API method [FC-0083] Apr 29, 2025
@bradenmacdonald
Copy link
Contributor

I tested, confirmed it's working, and released a new openedx-learning version with the changes. Please update this PR and I can merge.

@rpenido rpenido force-pushed the rpenido/fal-4144/fix-deleted-unit-re-appears branch 2 times, most recently from a30d786 to a21b569 Compare April 30, 2025 19:08
@rpenido rpenido changed the title fix: update openedx-learning to fix a bug where deleted containers were returned on the get_containers API method [FC-0083] fix: update openedx-learning to fix a bug where deleted containers were returned on the get_containers API method [FC-0083] Apr 30, 2025
Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido Is this safe to merge? It's still marked as a draft.

@bradenmacdonald bradenmacdonald added the FC Relates to an Axim Funded Contribution project label Apr 30, 2025
@rpenido rpenido marked this pull request as ready for review April 30, 2025 19:38
@rpenido
Copy link
Contributor Author

rpenido commented Apr 30, 2025

@rpenido Is this safe to merge? It's still marked as a draft.

Now it is! Was just testing again after updating the dependencies.

@rpenido rpenido force-pushed the rpenido/fal-4144/fix-deleted-unit-re-appears branch from a21b569 to 70deae5 Compare April 30, 2025 19:57
@rpenido
Copy link
Contributor Author

rpenido commented Apr 30, 2025

@bradenmacdonald Someone needs to create the open-release/teak.master before we backport this, right?

@bradenmacdonald
Copy link
Contributor

@rpenido It's now called release/teak.master

@bradenmacdonald bradenmacdonald merged commit 174cd58 into openedx:master Apr 30, 2025
49 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Apr 30, 2025
@bradenmacdonald bradenmacdonald deleted the rpenido/fal-4144/fix-deleted-unit-re-appears branch April 30, 2025 20:36
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants