Update social media links in EdX footer. #7383
Conversation
Replaces some PLATFORM_* settings with a more general setting for specifying social media URLs in the footer. Adds icons and titles for new social media sites (Tumblr, Reddit, Youtube) to match EdX.org.
|
This will require some changes to the config repo as well: https://github.com/edx/configuration/pull/1904 |
| @@ -51,11 +51,6 @@ | |||
|
|
|||
| PLATFORM_FACEBOOK_ACCOUNT = "http://www.facebook.com/YourPlatformFacebookAccount" | |||
| PLATFORM_TWITTER_ACCOUNT = "@YourPlatformTwitterAccount" | |||
| PLATFORM_TWITTER_URL = "https://twitter.com/YourPlatformTwitterAccount" | |||
There was a problem hiding this comment.
It looks like these are still used on the LMS course about page for white label.
There was a problem hiding this comment.
Hmm, I can't seem to find them when I grep the code base. (I'm finding the _ACCOUNT settings, which aren't deleted, but not the _URL settings).
There was a problem hiding this comment.
ah my mistake, I found PLATFORM_TWITTER_ACCOUNT, not URL. You should be all
set!
On Tue, Mar 17, 2015 at 1:37 PM, Will Daly notifications@github.com wrote:
In lms/envs/common.py
https://github.com/edx/edx-platform/pull/7383#discussion_r26595974:@@ -51,11 +51,6 @@
PLATFORM_FACEBOOK_ACCOUNT = "http://www.facebook.com/YourPlatformFacebookAccount"
PLATFORM_TWITTER_ACCOUNT = "@YourPlatformTwitterAccount"
-PLATFORM_TWITTER_URL = "https://twitter.com/YourPlatformTwitterAccount"Hmm, I can't seem to find them when I grep the code base. (I'm finding the
_ACCOUNT settings, which aren't deleted, but not the _URL settings).—
Reply to this email directly or view it on GitHub
https://github.com/edx/edx-platform/pull/7383/files#r26595974.
|
One comment to update the about page if needed, after that, ship it; 👍 |
Update social media links in EdX footer.
JIRA: ECOM-1134
@stephensanchez please review