Added videoalpha to advanced components in component.py file. #8
Conversation
ghost
assigned 
|
Good to go. |
|
+1 |
|
We just talked about this list of advanced components in an RCA. We have no tests that the list works properly (that the strings in the list are valid advanced xmodules). We've had 2 hotfixes around the list being improperly formatted. Therefore, the decision at the RCA was that the next person to touch this list needed to write some tests around it. Hate to be the bearer of bad news, but I can't give a thumbs-up with tests (in particular, that "videoalpha" translates into the correct xmodule). |
|
Is this PR blocking Stanford? My understanding was that video alpha was working but users had to manually add to the list of advanced modules first. Or is my understand wrong? If this isn't a blocker then lets wait for tests. If it really is a blocker, then maybe I can look into writing a test tonight. Sent from my iPhone On May 31, 2013, at 4:09 PM, Christina Roberts notifications@github.com wrote:
|
|
The problem is that you can't add videoalpha via AdvancedSettings unless it is in this list. I don't know when it got removed... perhaps merge conflicts? This line of code has been responsible for 2 hotfixes (in 2 consecutive weeks). |
|
Ok, sounds like a blocker. I'll try to write test tonight as I presume the Ukraine is away for weekend. Sent from my iPhone On May 31, 2013, at 5:11 PM, "Christina Roberts" notifications@github.com wrote:
|
|
Just FYI: It's important enough that we already cherry-picked this commit into edx-west/release and have it on our site. So far, it's been working (video is showing up, speeds are changing, captions are working), modulo some bugs re: changing speeds when video is playing, which we will file |
…he edit unit page when turned on
|
@cahrens @jbau @Lyla-Fischer @valera-rozuvan @auraz @vaxXxa As per Christina's request, added simple unit test to assert that the advanced modules appear in the edit unit page as expected. This probably should be a Lettuce test at some point, but we can do some basics as unit tests |
| self.assertIn('Video Alpha', resp.content) | ||
| self.assertIn('Word cloud', resp.content) | ||
| self.assertIn('Annotation', resp.content) | ||
| self.assertIn('Open Ended Response', resp.content) |
There was a problem hiding this comment.
Can you add peer grading as well? (It is correct that Notes will not appear in the list.)
|
A reasonable first test-- thanks, Chris. 👍 once you add a check for peer grading. |
Added videoalpha to advanced components in component.py file.
|
@chrisndodge thank you |
|
@chrisndodge = ) You are great! Thanks. |
Оценивание по вертикалям
changed label text for consistency
# This is the 1st commit message: ENT-385 change error msg for confirm email # This is the commit message #2: remove changed msgid from po files # This is the commit message #3: add name to AUTHORS file # This is the commit message #4: remove lastfailed file # This is the commit message #5: GradingPolicyChanged Signal Handler https://openedx.atlassian.net/browse/EDUCATOR-393 # This is the commit message #6: EDUCATOR-435 | Include enrollment status in in course and problem grade reports. # This is the commit message #7: Change visibility to access. EDUCATOR-396 # This is the commit message #8: LEARNER-923 Make Pattern Library support tabs transparent # This is the commit message #9: Conform to WCAG 2 AA contrast minimums for Google OAuth. Also apply variables for FB/Linkedin OAuth2 rather than leave color hashes hanging around. # This is the commit message #10: Updated auto_auth endpoint to always return JSON Defaulting to a plaintext response makes no sense for an endpoint that is intended to be used by machines for testing. The endpoint now returns JSON only unless a redirect action is triggered. # This is the commit message #1: Fix the activation email support link in the dashboard sidebar # This is the commit message #2: Mask grades on progress page according to "Show Correctness" setting. # This is the commit message #3: More celery logging # This is the commit message #4: Eventing for grading policy change # This is the commit message #5: More specific grace_course logging # This is the commit message #6: Add course overrides of waffle flags. # This is the commit message #7: Mark test as flaky, and remove flaky from a fixed test. EDUCATOR-511 # This is the commit message #8: Fix for LEARNER-859: Updating styling on the course updates page to more clearly differentiate between multiple updates. Specifically: - Updated styling on date in the top left corner - Added horizontal line between updates - Removed ability to toggle updates on and off - Cleaned up code to always show all updates:
Added utils file and agent field in BaseTransformer
Fix test failures
This custom image includes the elasticsearch-head plugin Fixes #8
Implemented custom APIs with custom response format Approved-by: Oksana Slusarenko
Valid courseware URLs currently include: * /course/:courseId * /course/:courseId/:sequenceId * /course/:courseId/:sequenceId/:unitId In this commit we add support for: * /course/:courseId/:sectionId * /course/:courseId/:sectionId/:unitId * /course/:courseId/:unitId All URL forms still redirect to: /course/:courseId/:sequenceId/:unitId See ADR openedx#8 for more context. All changes: * refactor: allow courseBlocks factory to build multiple sections * refactor: make CoursewareContainer tests less brittle & stateful * feat: handle courseware paths more liberally * refactor: reorder, rename, & comment redirection functions TNL-7796
Without this, Video Alpha will not appear under the Advanced Components section. It escapes me how this was missed in the original pull request https://github.com/edx/edx-platform-pre-clean/pull/1714 which was merged recently.
@vaxXxa and @auraz please review!