-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support team UI for regenerating certificates #9240
Conversation
@@ -0,0 +1,11 @@ | |||
;(function (define) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlasdairSwan These are the files I need you to review. Hooray for RequireJS optimizer in the LMS!
Looks good 👍 |
5371727
to
84f69dc
Compare
Tested this on a sandbox for both XQueue and webview certificates. Everything seems to be working as expected. @rlucioni when you have a chance, could you please review the Python changes? |
return response | ||
|
||
# Check that the course exists | ||
course = modulestore().get_course(params["course_key"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use the CourseOverview cache here instead of hitting the modulestore directly?
* Add new role for support staff. * Move dashboard/support functionality into a new Django app called "support". * Add support view for searching and regenerating certificates. * Refactor certificates views into separate files.
84f69dc
to
ad9d9eb
Compare
@rlucioni Unfortunately, the course gets passed down to
|
@wedaly that's likely because the CourseOverview object being passed down doesn't cache the With that said, I can see how this would be outside the scope of your work here. If you choose not to address it now, it might be worth adding a ticket to the backlog for. Whichever you choose, 👍 . |
Support team UI for regenerating certificates
Allow support staff to view and regenerate certificates.
JIRA: ECOM-1781
Screenshots
Reviewers
Apologies in advance for the large PR! I couldn't think of a reasonable way to break these changes into smaller PRs, so I'm going to assign people to review particular parts of this PR.
@AlasdairSwan could you please review the JavaScript and underscore templates in the
support
app?@rlucioni could you please review the Python changes in the
certificates
app?FYI: @mattdrayer I refactored the certificates views into separate files, since the
views.py
file was getting pretty crowded. I'm pretty sure this UI will work for webview certificates, with the exception of the "download URL" in the search results. I'm going to set up a sandbox to test this with webview certs before merging.