feat: [FC-86] add sorting feature for engines + enable_course_sorting_by_star…#205
Conversation
|
Thanks for the pull request, @andrii-hantkovskyi! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
d91e7b7 to
4902ca5
Compare
4902ca5 to
91315d2
Compare
|
Hi @diana-villalvazo-wgu would you have a chance to review this PR when you have a moment? |
|
@andrii-hantkovskyi Since this PR is approved, can we go ahead and merge it? Looking forward to it. |
@Abdul-Muqadim-Arbisoft Hi! I'm stepping in for @andrii-hantkovskyi. We will have one final look at this and move forward with a merge. |
|
Hi all, what's the status on this PR? It has an approval from July 21st. It's blocking work on the Catalog MFE. Can we get it merged? |
@sarina Hi! We see no problems with this PR, so you can safely merge it. |
|
I'm not a CC on this repo. @ormsbee was there a reason you didn't merge this after your approval? |
|
@Ali-Salman29 can you merge and release this change? |
|
@sarina: I didn't merge at the time because I thought the team would want to control the merge timing/rollout, and I had assumed someone on the team had access to do so. I'll just merge it now. |
We didn't bump the version when #205 landed. This change bumps the version so we can release the new version of the library.
|
FYI, it looks like we didn't bump the verison or publish the repo so I'll do that now. #224 bumps the version. |
Add Sorting Feature for Engines +
enable_course_sorting_by_start_dateParameterThis PR introduces a sorting feature for search engines and adds a new parameter,
enable_course_sorting_by_start_date, to the course discovery search.Key changes:
enable_course_sorting_by_start_dateto the course discovery search API, allowing results to be sorted by course start date when enabled.SortFielddataclass andFieldTypesenum to support flexible sorting across different search engines.sort_byparameter.startas a sortable field.These changes allow consumers to opt into sorting course results by start date, enabling richer search and browsing experiences across all supported backends.