Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update codecov action version #241

Merged
merged 3 commits into from
May 15, 2024
Merged

build: update codecov action version #241

merged 3 commits into from
May 15, 2024

Conversation

pomegranited
Copy link
Contributor

@pomegranited pomegranited commented May 1, 2024

@openedx-webhooks
Copy link

Thanks for the pull request, @pomegranited! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@kdmccormick
Copy link
Member

closing/opening to see if codecov works now (openedx/axim-engineering#1125)

@kdmccormick kdmccormick reopened this May 14, 2024
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion to run Coverage with the latest python, looks good otherwise!

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Co-authored-by: Kyle McCormick <kyle@kylemccormick.me>
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.33%. Comparing base (5273df1) to head (1eb1bad).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
- Coverage   93.43%   92.33%   -1.11%     
==========================================
  Files          18       18              
  Lines        1995     1995              
  Branches      130      268     +138     
==========================================
- Hits         1864     1842      -22     
  Misses        118      118              
- Partials       13       35      +22     
Flag Coverage Δ
unittests 92.33% <ø> (-1.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pomegranited
Copy link
Contributor Author

Since this is just a CI change, the coverage diff failure can be ignored.

@pomegranited pomegranited merged commit 680e44b into master May 15, 2024
14 of 15 checks passed
@pomegranited pomegranited deleted the jill/codecov-v4 branch May 15, 2024 23:41
@openedx-webhooks
Copy link

@pomegranited 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants