Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: advertise constraints in setup.py #143

Merged
merged 3 commits into from
May 30, 2024

Conversation

edx-requirements-bot
Copy link
Contributor

Additional information from script execution

ARCHBOM-1772
Update setup.py to use constraint files when generating requirements files for packaging and distribution.
PR generated automatically with Jenkins job cleanup-python-code.

Result of running python setup.py bdist_wheel before applying fix (in .egg-info/requires.txt):

django-model-utils>=2.3.1
jsonfield
djangorestframework<3.13.0
Django
pytz

Result of running python setup.py bdist_wheel after applying fix (in .egg-info/requires.txt):

django-model-utils>=2.3.1
jsonfield
djangorestframework<3.13.0
Django
pytz

Python code cleanup by the cleanup-python-code Jenkins job.

This pull request was generated by the cleanup-python-code Jenkins job, which ran
curl -sS "https://raw.githubusercontent.com/edx/edx-cookiecutters/e30fd05e343b8c73acb4dd8a3a6308c6f8efb4ad/scripts/update_setup_py.sh" > update_setup_py.sh
bash update_setup_py.sh

The following packages were installed:
semgrep,isort

@rgraber rgraber marked this pull request as ready for review November 8, 2021 14:04
@pomegranited pomegranited merged commit a4248bb into master May 30, 2024
16 checks passed
@pomegranited pomegranited deleted the jenkins/cleanup-python-code-d1a78ca branch May 30, 2024 01:44
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this by running python setup.py bdist_wheel and checking that the resulting egg requires.txt is valid, and unchanged.
  • I read through the code and ensured it was consistent with the current cookiecutter-django-ida guidelines.
  • I checked for accessibility issues N/A
  • Includes documentation N/A
  • User-facing strings are extracted for translation N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants