Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feanil/update rtd docs #208

Merged
merged 5 commits into from
Aug 31, 2023
Merged

feanil/update rtd docs #208

merged 5 commits into from
Aug 31, 2023

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Aug 7, 2023

This repo has a ReadTheDocs project that is currently broken, in making fixes for an upcoming RTD config deprecation, I noticed there were other issues with this repo. Rather than dropping this from RTD, I'm fixing forward so that this repo has docs that are in compliance with our latest standards and that will not have issues with the RTD config deprecation late next month.

  • docs: Add a ReadTheDocs config.
  • docs: Move to the new sphinx book theme.
  • docs: Update to be able to pull in docstrings.
  • docs: Update docstrings to not throw warnings.
  • chore: Run make upgrade

This format of config in the repo will be required starting in september
so add it now in preparation for that.
We need to actually setup django and its requirements to be able to
render autodocs.
Some of the docstrings were throwing warnings when we were trying to
render them in the docs site.  Update the docstrings so they don't throw
warnings.
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (170db9e) 93.43% compared to head (9844039) 93.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #208   +/-   ##
=======================================
  Coverage   93.43%   93.43%           
=======================================
  Files          18       18           
  Lines        1995     1995           
  Branches      130      130           
=======================================
  Hits         1864     1864           
  Misses        118      118           
  Partials       13       13           
Flag Coverage Δ
unittests 93.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
submissions/api.py 86.76% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kdmccormick
Copy link
Member

Everything looks good, but could you add some context for these changes? e.g., what's the desired end state we're going for?

Looking at https://github.com/openedx/edx-submissions/tree/master/docs/source, this repo contains no RST docs. So, is the point of this to be able to publish docstrings on docs.openedx.org or elsewhere?

@feanil
Copy link
Contributor Author

feanil commented Aug 29, 2023

@kdmccormick ah, thanks, yeas added some context to the PR description. It kind of snowballed from dealing with a deprecation on the RTD side.

Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@feanil feanil merged commit fdb0bfa into master Aug 31, 2023
8 checks passed
@feanil feanil deleted the feanil/update_rtd_docs branch August 31, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants