feat: adding python3.11 and 3.12 support #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #227 +/- ##
=======================================
Coverage 93.43% 93.43%
=======================================
Files 18 18
Lines 1995 1995
Branches 130 130
=======================================
Hits 1864 1864
Misses 118 118
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
UsamaSadiq
reviewed
Feb 26, 2024
awais786
force-pushed
the
support-pythons
branch
5 times, most recently
from
cecd5d0
to
008e535
Compare
UsamaSadiq
force-pushed
the
support-pythons
branch
from
008e535
to
429b408
Compare
awais786
force-pushed
the
support-pythons
branch
from
8e71efa
to
51e93db
Compare
awais786
changed the title
feanil
approved these changes
Mar 29, 2024
feanil
changed the title
feanil
changed the title
feanil
changed the title
UsamaSadiq
reviewed
Apr 1, 2024
| @@ -23,7 +22,8 @@ commands = | |||
| make test_quality | |||
|
|
|||
| [testenv:docs] | |||
| deps = | |||
| deps = | |||
| setuptools | |||
There was a problem hiding this comment.
This shouldn't be needed for Python 3.11 support as setuptools is removed in Python 3.12.
UsamaSadiq
reviewed
Apr 1, 2024
Makefile
Outdated
| # Make sure to compile files after any other files they include! | ||
| pip-compile --upgrade --allow-unsafe --rebuild -o requirements/pip.txt requirements/pip.in | ||
| pip-compile --upgrade --verbose --rebuild -o requirements/pip-tools.txt requirements/pip-tools.in | ||
| pip-compile --upgrade --allow-unsafe --verbose --rebuild -o requirements/pip-tools.txt requirements/pip-tools.in |
There was a problem hiding this comment.
--allow-unsafe shouldn't be needed for Python 3.11 support.
awais786
changed the title
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openedx/public-engineering#233
Python 3.11 and 3.12 support.