feat: add pathway association in algolia objects and sort results #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HammadAhmadWaqas
requested changes
Jul 5, 2022
| Returns: | ||
| bool: True if available via association else False | ||
| """ | ||
| return bool(pathway.get('visible_via_association', False)) |
There was a problem hiding this comment.
visible_via_association is already a boolean field, Why do we need this method?
| @@ -1080,6 +1095,7 @@ def _algolia_object_from_product(product, algolia_fields): | |||
| 'card_image_url': get_pathway_card_image_url(searchable_product), | |||
| 'partners': get_pathway_partners(searchable_product), | |||
| 'subjects': get_pathway_subjects(searchable_product), | |||
| 'visible_via_association': get_pathway_association(searchable_product), | |||
There was a problem hiding this comment.
visible_via_association should be already available here in searchable_product as a boolean field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Description of changes made
Ticket Link
Link to the associated ticket
Link title
Post-review