Adding v2 of catalog-based get_content_metadata endpoint #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmakwana93
force-pushed
the
pmakwana93/ENT-9406
branch
from
549925b
to
7bb2fe6
Compare
pmakwana93
force-pushed
the
pmakwana93/ENT-9406
branch
from
ac80e4e
to
3b496a0
Compare
| 'key': 'course-v1:edX+course+run2', | ||
| 'status': 'published', | ||
| 'is_enrollable': True, | ||
| 'is_marketable': True, |
There was a problem hiding this comment.
nit: just to make the data more prod-like, could we try setting is_marketable: False?
| }, | ||
| ) | ||
| @ddt.unpack | ||
| def test_get_content_metadata( |
There was a problem hiding this comment.
Consider adding one or maybe two more test cases where no content keys filter is passed in the GET request, and the catalog query either allows or does not allow a restricted run.
iloveagent57
force-pushed
the
pmakwana93/ENT-9406
branch
from
180b149
to
11274ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding v2 of catalog-based get_content_metadata endpoint
JIRA: https://2u-internal.atlassian.net/browse/ENT-9406
Post-review