-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding v2 of catalog-based get_content_metadata endpoint #983
base: master
Are you sure you want to change the base?
Conversation
549925b
to
7bb2fe6
Compare
ac80e4e
to
3b496a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good. One suggestion to add a test case or two, after that I think it'll be ready to go.
'key': 'course-v1:edX+course+run2', | ||
'status': 'published', | ||
'is_enrollable': True, | ||
'is_marketable': True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: just to make the data more prod-like, could we try setting is_marketable: False
?
}, | ||
) | ||
@ddt.unpack | ||
def test_get_content_metadata( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding one or maybe two more test cases where no content keys filter is passed in the GET request, and the catalog query either allows or does not allow a restricted run.
180b149
to
11274ab
Compare
Adding v2 of catalog-based get_content_metadata endpoint
JIRA: https://2u-internal.atlassian.net/browse/ENT-9406
Post-review