feanil/fix 3.12 tests #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The backports.zoneinfo package is not needed after python 3.8 so if we run `make upgrade` with python 3.12 it doesn't get added but it is still needed for Python 3.8 testing. So we explicitly add it to `base.in` with an environment marker so that it gets added for 3.8 but not 3.12 at install time and we have requirements that are forward compatible. We put the restriction in test.in because putting it in base.in causes issues with how we pull that requirement via the `load_requirements` function in setup.py
|
Closing this one, I think #88 is a better option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make upgrade