Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial repo maintenance #343

Merged
merged 5 commits into from
Sep 20, 2023
Merged

Initial repo maintenance #343

merged 5 commits into from
Sep 20, 2023

Conversation

@salman2013 salman2013 marked this pull request as ready for review August 30, 2023 10:53
@salman2013 salman2013 requested a review from a team August 30, 2023 10:53
spec:

# (Required) This can be a group(`group:<group_name>` or a user(`user:<github_username>`)
owner: "group:committers-event-routing-backends"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmtcril is this accurate or should it be some other group?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @openedx/arbi-bom are the maintainers of this repo to it should be updated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, was that by default? I think that potentially this should be Edly. Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually i found from this reference that committers-event-routing-backends has this repo.
Screenshot 2023-09-06 at 11 21 41 PM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure who is supposed to own it, but the actual maintainers and admins on the repo are currently these:

Screenshot 2023-09-07 at 9 27 14 AM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmtcril should i updated the owner to @openedx/arbi-bom?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like @ziafazal is going to be the / a official maintainer. Zia, do you want this set to yourself or to a group?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salman2013 yes please set it to edly

       team_reviewers: 'edly'
       email_address: 'admin@edly.io'

@@ -13,8 +13,8 @@ jobs:
call-upgrade-python-requirements-workflow:
with:
branch: ${{ github.event.inputs.branch }}
team_reviewers: 'axim-aximprovements'
email_address: 'aximimprovements@axim.org'
team_reviewers: 'edly'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edly is not a valid github team right now so I think it can just go to the e-mail address and this line can be commented for now.

@ziafazal if you want that team to exist and have you and others who are CCs and members of the openedx org added to it, let us know and we can create it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feanil I have commented the team reviewer for now.

Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing and then I think we can merge this.

spec:

# (Required) This can be a group(`group:<group_name>` or a user(`user:<github_username>`)
owner: "group:edly"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salman2013 since this github group doesn't exist, can you just mae this user:ziafazal and we can update it to a team later if we setup a github team. Sorry I missed this the last round.

Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good for now, @ziafazal feel free to make further changes as you see fit.

@feanil feanil merged commit 0c23955 into master Sep 20, 2023
9 checks passed
@feanil feanil deleted the salman/initial-repo-maintenance branch September 20, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants