-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial repo maintenance #343
Conversation
catalog-info.yaml
Outdated
spec: | ||
|
||
# (Required) This can be a group(`group:<group_name>` or a user(`user:<github_username>`) | ||
owner: "group:committers-event-routing-backends" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmtcril is this accurate or should it be some other group?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe @openedx/arbi-bom are the maintainers of this repo to it should be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, was that by default? I think that potentially this should be Edly. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmtcril should i updated the owner to @openedx/arbi-bom?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds like @ziafazal is going to be the / a official maintainer. Zia, do you want this set to yourself or to a group?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@salman2013 yes please set it to edly
team_reviewers: 'edly'
email_address: 'admin@edly.io'
@@ -13,8 +13,8 @@ jobs: | |||
call-upgrade-python-requirements-workflow: | |||
with: | |||
branch: ${{ github.event.inputs.branch }} | |||
team_reviewers: 'axim-aximprovements' | |||
email_address: 'aximimprovements@axim.org' | |||
team_reviewers: 'edly' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edly
is not a valid github team right now so I think it can just go to the e-mail address and this line can be commented for now.
@ziafazal if you want that team to exist and have you and others who are CCs and members of the openedx
org added to it, let us know and we can create it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feanil I have commented the team reviewer for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing and then I think we can merge this.
catalog-info.yaml
Outdated
spec: | ||
|
||
# (Required) This can be a group(`group:<group_name>` or a user(`user:<github_username>`) | ||
owner: "group:edly" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@salman2013 since this github group doesn't exist, can you just mae this user:ziafazal
and we can update it to a team later if we setup a github team. Sorry I missed this the last round.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good for now, @ziafazal feel free to make further changes as you see fit.
Description: Initial repo maintenance as per https://docs.openedx.org/en/latest/developers/how-tos/maintain-a-repo.html#how-to-maintain-a-repository
Ticket: https://github.com/orgs/openedx/projects/55/views/1?pane=issue&itemId=36191003