feat: migrate APIs from HTTPs to python calls#90
Merged
Faraz32123 merged 15 commits intomasterfrom Oct 2, 2024
Merged
Conversation
Faraz32123
force-pushed
the
feat/migrate_from_http_to_python_call
branch
6 times, most recently
from
95a0788 to
80b6084
Compare
regisb
reviewed
Sep 12, 2024
Contributor
regisb
left a comment
regisb
left a comment
There was a problem hiding this comment.
Let's make this more native :) And don't forget unit tests!
Faraz32123
force-pushed
the
feat/migrate_from_http_to_python_call
branch
4 times, most recently
from
eeec545 to
7eea53f
Compare
regisb
reviewed
Sep 17, 2024
regisb
reviewed
Sep 17, 2024
Faraz32123
force-pushed
the
feat/migrate_from_http_to_python_call
branch
2 times, most recently
from
ad844c8 to
555b3b7
Compare
- add pin, unpin, commentables count_stats and get user's data by user id python calls that'll be used by edx-platform instead of HTTPs
- call python native APIs in V2 HTTPs APIs
- add create_child_comment, create_parent_comment, delete_comment, get_parent_comment, update_comment, python calls that'll be used by edx-platform instead of HTTPs
- code refactor - pass params instead of a single dict to python native APIs - add proper docstrings - move those functions to model_utils which are accessing models
Faraz32123
force-pushed
the
feat/migrate_from_http_to_python_call
branch
2 times, most recently
from
4de5e72 to
1332e74
Compare
- add responses for create_parent_comment, create_child_comment, update_comment, get_commentables_stats, get_parent_comment, get_user, pin_thread, unpin_thread native APIs
Faraz32123
force-pushed
the
feat/migrate_from_http_to_python_call
branch
from
1332e74 to
a93a8c1
Compare
Faraz32123
force-pushed
the
feat/migrate_from_http_to_python_call
branch
from
429394c to
fc09a41
Compare
Faraz32123
force-pushed
the
feat/migrate_from_http_to_python_call
branch
from
1da77a5 to
b520231
Compare
Faraz32123
force-pushed
the
feat/migrate_from_http_to_python_call
branch
from
a5439df to
bc1d351
Compare
Ali-Salman29
approved these changes
Oct 2, 2024
taimoor-ahmed-1
approved these changes
Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
here's the related PR from edx-platform : openedx/openedx-platform#35490