Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove learn more about IDV button #1141

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

alangsto
Copy link
Contributor

Description

The "Learn more about ID Verification" button that is displayed as part of the failed IDV notification lead to an inaccessible link. The button should be removed to prevent confusion.

How Has This Been Tested?

  • Create a verified name via django admin for your test user, and mark the verified name as rejected
  • Load the account settings page and ensure the "Learn more about ID Verification" button is not included in the verified name alert

Screenshots/sandbox (optional):

Before After
verified_name_before Screenshot 2024-10-21 at 2 45 20 PM

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@alangsto alangsto force-pushed the alangsto/update_idv_failure_message branch from a10bc11 to d4e107a Compare October 21, 2024 18:54
@alangsto alangsto force-pushed the alangsto/update_idv_failure_message branch from d4e107a to a37be2d Compare October 21, 2024 18:58
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.61%. Comparing base (d0fdc2a) to head (a37be2d).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1141   +/-   ##
=======================================
  Coverage   58.61%   58.61%           
=======================================
  Files         117      117           
  Lines        2317     2317           
  Branches      641      641           
=======================================
  Hits         1358     1358           
  Misses        898      898           
  Partials       61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alangsto alangsto merged commit ee7c769 into master Oct 21, 2024
11 checks passed
@alangsto alangsto deleted the alangsto/update_idv_failure_message branch October 21, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants