Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include paragon in atlas pull #833

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

OmarIthawi
Copy link
Member

This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

feat: include paragon in atlas pull

This is a follow up to #818 because it should have included the changes but apparently OEP-58 needs more publicity.

Testing

I've ran the following:

$ OPENEDX_ATLAS_PULL=yes make pull_translations
$ cat src/i18n/index.js

Generates the following code, which seems to be good:

// This file is generated by the openedx/frontend-platform's "intl-import.js" script.
//
// Refer to the i18n documents in https://docs.openedx.org/en/latest/developers/references/i18n.html to update
// the file and use the Micro-frontend i18n pattern in new repositories.
//

import messagesFromParagon from './messages/paragon';
import messagesFromFrontendComponentHeader from './messages/frontend-component-header';
import messagesFromFrontendComponentFooter from './messages/frontend-component-footer';
import messagesFromFrontendAppAccount from './messages/frontend-app-account';

export default [
  messagesFromParagon,
  messagesFromFrontendComponentHeader,
  messagesFromFrontendComponentFooter,
  messagesFromFrontendAppAccount,
];

References

This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.

Join the conversation on Open edX Slack #translations-project-fc-0012.

Check the links above for full information about the overall project.

Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:

  • Remove source and language translations from the repositories, hence no .json, .po or .mo files will be committed into the repos.
  • Add standardized make extract_translations in all repositories
  • Push user-facing messages strings into openedx/openedx-translations.
  • Integrate root repositories with openedx/openedx-atlas to pull translations on build/deploy time

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 23, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d66dcec) 46.13% compared to head (5711f4d) 46.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #833   +/-   ##
=======================================
  Coverage   46.13%   46.13%           
=======================================
  Files         121      121           
  Lines        2525     2525           
  Branches      666      666           
=======================================
  Hits         1165     1165           
  Misses       1284     1284           
  Partials       76       76           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@brian-smith-tcril brian-smith-tcril added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Jul 24, 2023
@abdullahwaheed abdullahwaheed merged commit 929a669 into openedx:master Jul 25, 2023
7 checks passed
@openedx-webhooks
Copy link

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@abdullahwaheed abdullahwaheed removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Jul 25, 2023
snglth pushed a commit to Abstract-Tech/community-theme-account that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants