Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Restore jump nav and content width [backport from master] #995

Open
wants to merge 1 commit into
base: open-release/quince.master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat: Restore jump nav and content width
Lunyachek committed Feb 8, 2024

Verified

This commit was signed with the committer’s verified signature.
colingm Colin Maxfield
commit f3e84f0adec1dacd6f5cca4537de7b847b76cee1
4 changes: 2 additions & 2 deletions src/account-settings/AccountSettingsPage.jsx
Original file line number Diff line number Diff line change
@@ -814,12 +814,12 @@ class AccountSettingsPage extends React.Component {
</h1>
<div>
<div className="row">
<div className="col-md-2">
<div className="col-md-3">
<JumpNav
displayDemographicsLink={this.props.formValues.shouldDisplayDemographicsSection}
/>
</div>
<div className="col-md-10">
<div className="col-md-9">
{loading ? this.renderLoading() : null}
{loaded ? this.renderContent() : null}
{loadingError ? this.renderError() : null}
2 changes: 1 addition & 1 deletion src/account-settings/JumpNav.jsx
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@ const JumpNav = ({
const showPreferences = useSelector(selectShowPreferences());

return (
<div className={classNames('jump-nav px-2.25', { 'jump-nav-sm position-sticky pt-3': stickToTop })}>
<div className={classNames('jump-nav', { 'jump-nav-sm position-sticky pt-3': stickToTop })}>
<Scrollspy
items={[
'basic-information',
4 changes: 2 additions & 2 deletions src/account-settings/test/__snapshots__/JumpNav.test.jsx.snap
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@

exports[`JumpNav should not render Optional Information or delete account link 1`] = `
<div
className="jump-nav px-2.25 jump-nav-sm position-sticky pt-3"
className="jump-nav jump-nav-sm position-sticky pt-3"
>
<ul
className="list-unstyled"
@@ -79,7 +79,7 @@ exports[`JumpNav should not render Optional Information or delete account link 1

exports[`JumpNav should render Optional Information and delete account link 1`] = `
<div
className="jump-nav px-2.25 jump-nav-sm position-sticky pt-3"
className="jump-nav jump-nav-sm position-sticky pt-3"
>
<ul
className="list-unstyled"