-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow runtime configuration #654
Conversation
Thanks for the pull request, @dcoa! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportBase: 81.01% // Head: 81.01% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #654 +/- ##
=======================================
Coverage 81.01% 81.01%
=======================================
Files 86 86
Lines 1849 1849
Branches 522 522
=======================================
Hits 1498 1498
Misses 336 336
Partials 15 15 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@zainab-amir, mind reviewing this one? It's required if we want to include it in Tutor/Olive. |
@arbrandes I have created a ticket for this in our current sprint. |
@zainab-amir, thanks! 👍🏼 |
@dcoa the changes look good. Kindly rebase the branch and I'll re-review it. |
86d3534
to
1219f05
Compare
Hi @zainab-amir, I already rebase the branch and made the suggested change :) |
@dcoa 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR is part of the work to make it possible to configure the frontend applications at runtime (you can referer to this openedx/wg-frontend#103).
Changes
Screenshot
Values come from runtime configuration
How to test
MFE_CONFIG_API_URL
andAPP_ID
in the env file and add the api url ( To test this you can use the API from this feat: add mfe config api edx-platform#30473 or use an external tool to mock the API response).Note: You can combine buildtime and runtime configuration