fix: -t flag added in pull translation command #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 81.01% // Head: 81.01% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #682 +/- ##
=======================================
Coverage 81.01% 81.01%
=======================================
Files 86 86
Lines 1849 1849
Branches 522 522
=======================================
Hits 1498 1498
Misses 336 336
Partials 15 15 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
UsamaSadiq
approved these changes
Nov 24, 2022
zainab-amir
approved these changes
Nov 25, 2022
zainab-amir
deleted the
jenkins/zshkoor/update-pull-translation-command-34f3240
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transifex command line tool we use to pull translations introduced a fix that broke the existing translation pulls. So, in order to fix this, I've updated thecommand to use the flag along with the existing flags. To get the more context on this, please have a look into this issue