Skip to content

Commit 6ad8074

Browse files
committed
chore: remove husky 🪓🐶
We remove husky, which is triggering pre-push git hooks, including running "npm lint". This is causing failures when building Docker images, because "npm clean-install --omit=dev" automatically triggers "npm prepare", which attemps to run "husky". But husky is not listed in the build dependencies, only in devDependencies. As a consequence, package installation is failing with the following error: 14.13 > @edx/frontend-app-ora-grading@0.0.1 prepare 14.13 > husky install 14.13 14.15 sh: 1: husky: not found Similar to: openedx/frontend-app-learning#1622
1 parent 0ce0b75 commit 6ad8074

File tree

2 files changed

+0
-23
lines changed

2 files changed

+0
-23
lines changed

package-lock.json

Lines changed: 0 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,6 @@
2323
"test:ci": "TZ=UTC fedx-scripts jest --silent --coverage --passWithNoTests",
2424
"types": "tsc --noEmit"
2525
},
26-
"husky": {
27-
"hooks": {
28-
"pre-commit": "npm run lint"
29-
}
30-
},
3126
"author": "edX",
3227
"license": "AGPL-3.0",
3328
"homepage": "https://github.com/openedx/frontend-app-authoring#readme",
@@ -120,7 +115,6 @@
120115
"axios-mock-adapter": "1.22.0",
121116
"eslint-import-resolver-webpack": "^0.13.8",
122117
"fetch-mock-jest": "^1.5.1",
123-
"husky": "7.0.4",
124118
"jest-canvas-mock": "^2.5.2",
125119
"jest-expect-message": "^1.1.3",
126120
"react-test-renderer": "^18.3.1",

0 commit comments

Comments
 (0)