-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add library component picker #1356
Merged
bradenmacdonald
merged 31 commits into
openedx:master
from
open-craft:rpenido/fal-3876-add-library-content-to-a-course
Oct 16, 2024
Merged
Changes from 9 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
cdfe3d6
feat: add library component picker
rpenido df9b518
feat: add api call
rpenido d8f3d7a
test: add tests
rpenido 7ca8f22
test: more tests
rpenido 45b2f01
test: try to fix flaky test
rpenido 08a7e48
test: improve coverage
rpenido be2765d
fix: some navigation fixes
rpenido 34f76e6
fix: more fixes
rpenido de1be9e
test: more coverage
rpenido 81bcd53
refactor: use muteteAsync instead of hooks
rpenido d1d9c1d
fix: eslint
rpenido 1ce80cb
fix: use routes
rpenido 4f6a485
fix: add arrow icon
rpenido c569d3e
refactor: use muteteAsync instead of hooks
rpenido 2a0c4ff
fix: make card clickable
rpenido dbb45b3
fix: add padding
rpenido 6d43547
fix: add useCallback to handleSearch
rpenido d77a7db
Merge branch 'master' into rpenido/fal-3876-add-library-content-to-a-…
rpenido 16e71fc
fix: eslint
rpenido 3a4497b
fix: issues from merge
rpenido 8431b67
fix: check readOnly on ManageCollections
rpenido 72f7b85
fix: remove min-height style
rpenido ded2f07
fix: add jsdocs
rpenido a31836e
fix: set activeKey with navigation
rpenido fdc54e7
test: fix tests
rpenido f57efb4
test: fix test
rpenido 9e82795
test: fix test
rpenido 78d25fb
fix: add padding
rpenido 5cc64cb
fix: remove add component when readOnly
rpenido 9709133
chore: remove unused import
bradenmacdonald 46babe0
test: revert change that broke flaky test
bradenmacdonald File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a flaky test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: you could just write
const feedbackLink = await findByText(...
instead of usingawait waitFor(() => {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here: 9e82795