Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show published components on content picker #1420

Merged

Conversation

ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Oct 22, 2024

Description

Updated the Content Picker to show published components.

  • Which edX user roles will this change impact? "Course Author"

Testing instructions

  • Create or use a library.
  • Create new components and publish the library
  • Follow instructions from PR: feat: add library component picker #1356 to add library components to a course.
  • Select the library and verify that only you can see the published components.
  • Create new components. Don't publish the library
  • Select the library on the content picker and verify that only you can see the published components (Don't see the new components).
  • Publish the library.
  • Select the library on the content picker and verify that only you can see the published components.
  • Update the title and descriptions of components. Don't publish the library.
  • On the content picker verify the title, description and preview of the components.
  • Publish the library.
  • On the content picker verify the title, description and preview of the components.

@ChrisChV ChrisChV requested a review from a team as a code owner October 22, 2024 01:43
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 22, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @ChrisChV!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.12%. Comparing base (841aede) to head (5826937).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1420      +/-   ##
==========================================
- Coverage   93.12%   93.12%   -0.01%     
==========================================
  Files        1051     1051              
  Lines       20171    20229      +58     
  Branches     4207     4315     +108     
==========================================
+ Hits        18784    18838      +54     
- Misses       1327     1331       +4     
  Partials       60       60              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisChV
Copy link
Contributor Author

@bradenmacdonald It's ready for review

@bradenmacdonald
Copy link
Contributor

@ChrisChV Nice work! Everything is great except there is some problem with the description - it's not being truncated anymore.

Screenshot 2024-10-21 at 8 02 24 PM

@bradenmacdonald
Copy link
Contributor

@ChrisChV I have the change here: openedx/edx-platform@23c2bb6 for using it in Studio. I'll include it in my PR openedx/edx-platform#35679

@ChrisChV
Copy link
Contributor Author

I will check the truncated issue tomorrow

Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisChV Looks good! I pushed a fix 5741374 for the issue that I noticed. Please check my fix and then merge this if it looks good :)

@ChrisChV ChrisChV merged commit 21cbf80 into openedx:master Oct 22, 2024
8 checks passed
@ChrisChV ChrisChV deleted the chris/FAL-3881-updated-content-picker branch October 22, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants