-
Notifications
You must be signed in to change notification settings - Fork 170
feat: lighter build by rewriting lodash imports #1772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @regisb! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
9179965 to
8b7b9d0
Compare
d120d2c to
05e3030
Compare
|
Issues are not related to this PR. This is ready for review. |
bradenmacdonald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM but let's get a green build before we merge.
|
Can you help me to figure out what's going on with the build? As far as I understand, other PRs in this repo face similar errors. |
bradenmacdonald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if these are all the issues, but these are some of the things causing test failures. If you rebase you'll also get some improvements that make the tests more robust, from the React 18 PR that recently merged.
...and-resources/discussions/app-config-form/apps/shared/discussion-topics/DiscussionTopics.jsx
Outdated
Show resolved
Hide resolved
...s/ProblemEditor/components/EditProblemView/SettingsWidget/settingsComponents/ScoringCard.jsx
Outdated
Show resolved
Hide resolved
src/pages-and-resources/discussions/app-config-form/apps/shared/DivisionByGroupFields.jsx
Outdated
Show resolved
Hide resolved
e8fbf1d to
66d6a8d
Compare
|
No problem. I actually tried to do a PR like this once myself, but ran into some challenge and move on to other things. So I'm glad to see you tackling it. Looks like you're down to only 1 failing test now :) |
Incorrect lodash imports are causing MFEs to import the entire lodash library. This change shaves off a few kB of the compressed build.
66d6a8d to
1d9fff6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1772 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 1136 1136
Lines 23205 23205
Branches 5000 4999 -1
=======================================
Hits 21708 21708
- Misses 1421 1429 +8
+ Partials 76 68 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
OK I think there might have been a flaky test... This should be good to merge now. |
Incorrect lodash imports are causing MFEs to import the entire lodash library. This change shaves off a few kB of every MFE compressed build.