-
Notifications
You must be signed in to change notification settings - Fork 182
fix: auto adjust min height of xblock previews [FC-0083] #1813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @navinkarkera! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
| const LARGE_COMPONENTS = [ | ||
| COMPONENT_TYPES.advanced, | ||
| COMPONENT_TYPES.dragAndDrop, | ||
| COMPONENT_TYPES.discussion, | ||
| 'lti', | ||
| 'lti_consumer', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChrisChV We just need to add block types that need larger min height, let me know if I missed any.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@navinkarkera For the previews those are fine 👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1813 +/- ##
==========================================
+ Coverage 93.55% 93.56% +0.01%
==========================================
Files 1136 1136
Lines 23245 23247 +2
Branches 5013 5013
==========================================
+ Hits 21746 21751 +5
+ Misses 1423 1420 -3
Partials 76 76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4b8ff19 to
aa51f80
Compare
|
@navinkarkera With this PR, I see the exact size issue for editors: https://www.loom.com/share/9f941ffc0b8b48a3a37ffe41e0bf2147?sid=01438a5f-a701-4c48-a76a-e94c52e72ac5 |
2a92a0d to
bb3a9b7
Compare
bb3a9b7 to
5a3f390
Compare
ChrisChV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@navinkarkera Thanks! Looks good! Could you fix the coverage to merge this PR?
Sets minimum height of library block previews based on its render location and block type.
5a3f390 to
55d3af7
Compare
|
@ChrisChV Done. |
Sets minimum height of library block previews based on its render
location and block type.
Ref: openedx/openedx-platform#36477 (comment)
Private-ref: https://tasks.opencraft.com/browse/FAL-4049Screenshots:
With large fixed size min-height, all blocks in unit page look big
After: