Skip to content

Conversation

@rpenido
Copy link
Contributor

@rpenido rpenido commented Aug 20, 2025

Description

This PR adds the Unlink feature to the Course Outline for Sections, Subsections and Units.

image image

Useful information to include:

  • Which user roles will this change impact?
    "Course Author",

Supporting information

Testing instructions

NOTE: This feature needs the top-parent level logic, so it can cause inconsistencies and will not work correctly with containers imported before openedx/openedx-platform@a1195ef

  • Create a nested Section, Subsection, Unit structure in a library and publish it
  • Create a new course and add the section to this course
  • Make some changes to the Section and Subsection on the library and publish both again
  • You can check that only the Section will be shown on the Content -> Library Updates page
  • Unlink the Section using the 3-dot menu on the Course Outline
  • Check that the page is refreshed and the library sync icon is removed from the Section
  • You can check that not only the Subsection will be shown on the Content -> Library Updates page

Other information

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Deprecated propTypes, defaultProps, and injectIntl patterns are not used in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Imports avoid using ../. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

Private ref: FAL-4225

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 20, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Aug 20, 2025

Thanks for the pull request, @rpenido!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Aug 20, 2025
@rpenido rpenido force-pushed the rpenido/fal-4225/unlink-downstream branch 5 times, most recently from 1218f1f to 3e34dea Compare August 21, 2025 12:47
@rpenido rpenido changed the title feat: add unlink upstream menu feat: add unlink upstream menu [FC-0097] Aug 21, 2025
@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

❌ Patch coverage is 99.04762% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.60%. Comparing base (0c88fd6) to head (e23e99d).
⚠️ Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
src/generic/key-utils.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2393      +/-   ##
==========================================
+ Coverage   94.55%   94.60%   +0.04%     
==========================================
  Files        1174     1179       +5     
  Lines       25366    25506     +140     
  Branches     5551     5574      +23     
==========================================
+ Hits        23984    24129     +145     
- Misses       1313     1314       +1     
+ Partials       69       63       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rpenido rpenido force-pushed the rpenido/fal-4225/unlink-downstream branch 5 times, most recently from dfc7c01 to a0d7bc5 Compare August 21, 2025 17:51
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Aug 21, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Aug 21, 2025
@rpenido rpenido force-pushed the rpenido/fal-4225/unlink-downstream branch from a0d7bc5 to 520bed9 Compare August 22, 2025 14:28
Copy link
Contributor

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido Looks good, Thanks! 👍

  • I tested this: (Unlinked different levels of blocks)
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@rpenido rpenido force-pushed the rpenido/fal-4225/unlink-downstream branch from f63bd5e to 16c61a0 Compare August 25, 2025 22:45
@rpenido rpenido marked this pull request as draft August 26, 2025 00:52
@rpenido rpenido force-pushed the rpenido/fal-4225/unlink-downstream branch 2 times, most recently from 6cf0fec to daf7e7f Compare August 26, 2025 19:52
@rpenido rpenido force-pushed the rpenido/fal-4225/unlink-downstream branch from daf7e7f to 6ac9fb1 Compare August 26, 2025 20:04
@rpenido rpenido marked this pull request as ready for review August 27, 2025 13:44
Co-authored-by: Navin Karkera <navin@opencraft.com>
@rpenido rpenido force-pushed the rpenido/fal-4225/unlink-downstream branch from 20ab86a to 8013dfc Compare August 27, 2025 13:45
Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! @rpenido Looks good! 👍 Only I left one nit

Comment on lines 279 to 282
it('calls onClickUnlink when item is clicked', async () => {
renderComponent();
});

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it duplicated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already tested in other places, but for completeness, I updated this test here: e23e99d

@rpenido rpenido force-pushed the rpenido/fal-4225/unlink-downstream branch from 9f15a6c to e23e99d Compare August 28, 2025 13:53
@ChrisChV ChrisChV merged commit 950bfee into openedx:master Aug 28, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions Aug 28, 2025
@rpenido rpenido deleted the rpenido/fal-4225/unlink-downstream branch August 28, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants