-
Notifications
You must be signed in to change notification settings - Fork 182
feat: add unlink upstream menu [FC-0097] #2393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add unlink upstream menu [FC-0097] #2393
Conversation
|
Thanks for the pull request, @rpenido! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
1218f1f to
3e34dea
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2393 +/- ##
==========================================
+ Coverage 94.55% 94.60% +0.04%
==========================================
Files 1174 1179 +5
Lines 25366 25506 +140
Branches 5551 5574 +23
==========================================
+ Hits 23984 24129 +145
- Misses 1313 1314 +1
+ Partials 69 63 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dfc7c01 to
a0d7bc5
Compare
a0d7bc5 to
520bed9
Compare
navinkarkera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rpenido Looks good, Thanks! 👍
- I tested this: (Unlinked different levels of blocks)
- I read through the code
- I checked for accessibility issues
- Includes documentation
f63bd5e to
16c61a0
Compare
6cf0fec to
daf7e7f
Compare
daf7e7f to
6ac9fb1
Compare
Co-authored-by: Navin Karkera <navin@opencraft.com>
20ab86a to
8013dfc
Compare
ChrisChV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! @rpenido Looks good! 👍 Only I left one nit
| it('calls onClickUnlink when item is clicked', async () => { | ||
| renderComponent(); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it duplicated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was already tested in other places, but for completeness, I updated this test here: e23e99d
9f15a6c to
e23e99d
Compare
Description
This PR adds the Unlink feature to the Course Outline for Sections, Subsections and Units.
Useful information to include:
"Course Author",
Supporting information
Testing instructions
NOTE: This feature needs the top-parent level logic, so it can cause inconsistencies and will not work correctly with containers imported before openedx/openedx-platform@a1195ef
Content -> Library UpdatespageContent -> Library UpdatespageOther information
unlinkableto xblock actions and updatetop_level_parent_keyon unlink [FC-0097] openedx-platform#37215Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypes,defaultProps, andinjectIntlpatterns are not used in any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'Private ref: FAL-4225