Skip to content

Conversation

@asadali145
Copy link
Contributor

Description

This PR backports #1867 to the release/teak branch. The original PR fixes a few issues like #2418 and #2246. Also, it has forced us to create 3 backports (2 merged in teak #2246, #2042, and 1 pending). After this PR, we can opt to revert the merged backports.

This PR has ~100 code changes, and all others are testing modifications.

Testing instructions

This handles loading errors when opening the course unit page via direct link as an unauthorized user.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 4, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @asadali145!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release/teak@41fc478). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/course-unit/data/thunk.js 93.33% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release/teak    #2424   +/-   ##
===============================================
  Coverage                ?   93.89%           
===============================================
  Files                   ?     1149           
  Lines                   ?    24076           
  Branches                ?     5095           
===============================================
  Hits                    ?    22606           
  Misses                  ?     1402           
  Partials                ?       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asadali145
Copy link
Contributor Author

@bradenmacdonald Can you please take a look at this backport PR?

@bradenmacdonald
Copy link
Contributor

@asadali145 Yes, I will review this. Is there anyone else from your team who can help test it and check for regressions? Manual testing is what takes me the longest, especially for backports.

Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this has been very stable on master as far as I know, I am more comfortable backporting it now, especially as it seems our other attempts to fix the bugs haven't been as effective.

@bradenmacdonald bradenmacdonald merged commit f459f53 into openedx:release/teak Sep 9, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Sep 9, 2025
@bradenmacdonald
Copy link
Contributor

@farhaanbukhsh Another backported fix.

Asespinel pushed a commit to eduNEXT/frontend-app-course-authoring that referenced this pull request Dec 14, 2025
This handles loading errors when opening the course unit page via direct link as an unauthorized user.

Co-authored-by: Ihor Romaniuk <ihor.romaniuk@raccoongang.com>
Asespinel pushed a commit to eduNEXT/frontend-app-course-authoring that referenced this pull request Dec 17, 2025
This handles loading errors when opening the course unit page via direct link as an unauthorized user.

Co-authored-by: Ihor Romaniuk <ihor.romaniuk@raccoongang.com>
Asespinel pushed a commit to eduNEXT/frontend-app-course-authoring that referenced this pull request Dec 17, 2025
This handles loading errors when opening the course unit page via direct link as an unauthorized user.

Co-authored-by: Ihor Romaniuk <ihor.romaniuk@raccoongang.com>
Asespinel pushed a commit to eduNEXT/frontend-app-course-authoring that referenced this pull request Dec 17, 2025
This handles loading errors when opening the course unit page via direct link as an unauthorized user.

Co-authored-by: Ihor Romaniuk <ihor.romaniuk@raccoongang.com>
Asespinel pushed a commit to eduNEXT/frontend-app-course-authoring that referenced this pull request Dec 18, 2025
This handles loading errors when opening the course unit page via direct link as an unauthorized user.

Co-authored-by: Ihor Romaniuk <ihor.romaniuk@raccoongang.com>
xitij2000 pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Dec 19, 2025
This handles loading errors when opening the course unit page via direct link as an unauthorized user.

Co-authored-by: Ihor Romaniuk <ihor.romaniuk@raccoongang.com>
xitij2000 pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Dec 19, 2025
This handles loading errors when opening the course unit page via direct link as an unauthorized user.

Co-authored-by: Ihor Romaniuk <ihor.romaniuk@raccoongang.com>
xitij2000 pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Dec 19, 2025
This handles loading errors when opening the course unit page via direct link as an unauthorized user.

Co-authored-by: Ihor Romaniuk <ihor.romaniuk@raccoongang.com>
xitij2000 pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Dec 19, 2025
This handles loading errors when opening the course unit page via direct link as an unauthorized user.

Co-authored-by: Ihor Romaniuk <ihor.romaniuk@raccoongang.com>
xitij2000 pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Dec 22, 2025
This handles loading errors when opening the course unit page via direct link as an unauthorized user.

Co-authored-by: Ihor Romaniuk <ihor.romaniuk@raccoongang.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants