-
Notifications
You must be signed in to change notification settings - Fork 178
[backport] fix: load sequences in unit page #2424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backport] fix: load sequences in unit page #2424
Conversation
This handles loading errors when opening the course unit page via direct link as an unauthorized user.
|
Thanks for the pull request, @asadali145! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/teak #2424 +/- ##
===============================================
Coverage ? 93.89%
===============================================
Files ? 1149
Lines ? 24076
Branches ? 5095
===============================================
Hits ? 22606
Misses ? 1402
Partials ? 68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@bradenmacdonald Can you please take a look at this backport PR? |
|
@asadali145 Yes, I will review this. Is there anyone else from your team who can help test it and check for regressions? Manual testing is what takes me the longest, especially for backports. |
bradenmacdonald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this has been very stable on master as far as I know, I am more comfortable backporting it now, especially as it seems our other attempts to fix the bugs haven't been as effective.
|
@farhaanbukhsh Another backported fix. |
This handles loading errors when opening the course unit page via direct link as an unauthorized user. Co-authored-by: Ihor Romaniuk <ihor.romaniuk@raccoongang.com>
This handles loading errors when opening the course unit page via direct link as an unauthorized user. Co-authored-by: Ihor Romaniuk <ihor.romaniuk@raccoongang.com>
This handles loading errors when opening the course unit page via direct link as an unauthorized user. Co-authored-by: Ihor Romaniuk <ihor.romaniuk@raccoongang.com>
This handles loading errors when opening the course unit page via direct link as an unauthorized user. Co-authored-by: Ihor Romaniuk <ihor.romaniuk@raccoongang.com>
This handles loading errors when opening the course unit page via direct link as an unauthorized user. Co-authored-by: Ihor Romaniuk <ihor.romaniuk@raccoongang.com>
This handles loading errors when opening the course unit page via direct link as an unauthorized user. Co-authored-by: Ihor Romaniuk <ihor.romaniuk@raccoongang.com>
This handles loading errors when opening the course unit page via direct link as an unauthorized user. Co-authored-by: Ihor Romaniuk <ihor.romaniuk@raccoongang.com>
This handles loading errors when opening the course unit page via direct link as an unauthorized user. Co-authored-by: Ihor Romaniuk <ihor.romaniuk@raccoongang.com>
This handles loading errors when opening the course unit page via direct link as an unauthorized user. Co-authored-by: Ihor Romaniuk <ihor.romaniuk@raccoongang.com>
This handles loading errors when opening the course unit page via direct link as an unauthorized user. Co-authored-by: Ihor Romaniuk <ihor.romaniuk@raccoongang.com>
Description
This PR backports #1867 to the release/teak branch. The original PR fixes a few issues like #2418 and #2246. Also, it has forced us to create 3 backports (2 merged in teak #2246, #2042, and 1 pending). After this PR, we can opt to revert the merged backports.
This PR has ~100 code changes, and all others are testing modifications.
Testing instructions