Skip to content

Conversation

@kdmccormick
Copy link
Member

@kdmccormick kdmccormick commented Oct 7, 2025

Description

BREAKING CHANGE: Removes Maintenance link in header, part of openedx/openedx-platform#36263 (the immediate purpose of this upgrade)

Full diff:
openedx/frontend-component-header@v6.2.0...v8.0.0

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Deprecated propTypes, defaultProps, and injectIntl patterns are not used in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Imports avoid using ../. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

BREAKING CHANGE: Removes Maintenance link in header, part of
openedx/openedx-platform#36263
(^ the immedaite purpose of this upgrade)

BREAKING CHANGE: Consuming applications must support typescript

Full diff:
openedx/frontend-component-header@v6.2.0...v8.0.0
@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.68%. Comparing base (8fe5fb6) to head (dfc5266).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2521      +/-   ##
==========================================
- Coverage   94.68%   94.68%   -0.01%     
==========================================
  Files        1203     1203              
  Lines       26865    26877      +12     
  Branches     6026     6031       +5     
==========================================
+ Hits        25438    25448      +10     
- Misses       1357     1359       +2     
  Partials       70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kdmccormick
Copy link
Member Author

@feanil , @bradenmacdonald , @brian-smith-tcril , could one of you take a look?

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Kind of frustrating that codecov is doing the up/down by 0.01% thing here but it's definitely not the fault of this PR.

@bradenmacdonald
Copy link
Contributor

Kind of frustrating that codecov is doing the up/down by 0.01% thing here but it's definitely not the fault of this PR.

For that reason, we've made the project check optional at reviewer's discretion on this repo.

@kdmccormick kdmccormick merged commit 1d6fdc3 into openedx:master Oct 10, 2025
6 of 7 checks passed
@kdmccormick kdmccormick deleted the kdmccormick/depr-maintenance branch October 10, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants